hg: jdk7/hotspot-rt/hotspot: 7017193: Small memory leak in get_stack_bounds os::create_stack_guard_pages

2011-03-31 Thread dmitriy . samersoff
Changeset: 677234770800 Author:dsamersoff Date: 2011-03-30 19:38 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/677234770800 7017193: Small memory leak in get_stack_bounds os::create_stack_guard_pages Summary: getline() returns -1 but still allocate memory for str

Re: code review for CR7007254

2011-03-31 Thread Tomas Hurka
Hi, I would like to resubmit this code review. I had the private discussion with Dan Daugherty and we agreed that it would be good to integrate the current fix I proposed below. Our reasoning is as follow: 1) It fixes the reported problem 2) The fix is not intended to address 5049313 (which talks

Re: code review for CR7007254

2011-03-31 Thread Kelly O'Hair
It's ok with me, but I'm not in the Serviceability team anymore. Make sure Dan is ok with it, or at least knows about it. -kto On Mar 31, 2011, at 1:58 AM, Tomas Hurka wrote: > Hi, > I would like to resubmit this code review. I had the private discussion with > Dan Daugherty and we agreed that

Re: code review for CR7007254

2011-03-31 Thread Daniel D. Daugherty
I'm OK with it and, in fact, I recommend doing the incremental improvement via 7007254 and leaving 5049313 for another day. Tomas and I IM'ed about it yesterday. Dan On 3/31/2011 9:20 AM, Kelly O'Hair wrote: It's ok with me, but I'm not in the Serviceability team anymore. Make sure Dan i

hg: jdk7/tl/jdk: 7032866: Problem with fix for 7030256

2011-03-31 Thread michael . x . mcmahon
Changeset: 683957148bab Author:michaelm Date: 2011-03-31 17:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/683957148bab 7032866: Problem with fix for 7030256 Reviewed-by: alanb ! src/windows/native/java/net/net_util_md.c

hg: jdk7/hotspot-rt/hotspot: 7032775: Include Shark code in the build again

2011-03-31 Thread david . holmes
Changeset: b025bffd6c2c Author:dholmes Date: 2011-03-31 06:54 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b025bffd6c2c 7032775: Include Shark code in the build again Reviewed-by: ohair Contributed-by: gben...@redhat.com, ahug...@redhat.com ! make/linux/makefil

Re: SA and JDK ( was Re: JDK8 Preliminary Repository Layout)

2011-03-31 Thread Dr Andrew John Hughes
On 31/03/2011, Daniel D. Daugherty wrote: > On 3/30/2011 7:08 PM, Alan Bateman wrote: >> Dr Andrew John Hughes wrote: >>> Ok, what's the best tree to post it against? I don't see a >>> serviceability tree, so I guess it'll be a HotSpot one... >>> >>> >> The runtime forest (http://hg.openjdk.java.

Re: SA and JDK ( was Re: JDK8 Preliminary Repository Layout)

2011-03-31 Thread Daniel D. Daugherty
On 3/31/2011 7:10 PM, Dr Andrew John Hughes wrote: If this looks ok, it needs a bug ID and then pushing to JPRT by some friendly Oracle HotSpot developer :-). Actually, I think we can use the following bug ID: 7010849 5/5 Extraneous javac source/target options when building sa-jdi if Da

Re: SA and JDK ( was Re: JDK8 Preliminary Repository Layout)

2011-03-31 Thread David Holmes
Daniel D. Daugherty said the following on 04/01/11 11:27: On 3/31/2011 7:10 PM, Dr Andrew John Hughes wrote: If this looks ok, it needs a bug ID and then pushing to JPRT by some friendly Oracle HotSpot developer :-). Actually, I think we can use the following bug ID: 7010849 5/5 Extrane

hg: jdk7/tl/jdk: 7005628: Clarify NPE behavior of Throwable.addSuppressed(null)

2011-03-31 Thread joe . darcy
Changeset: 856cc9e97aea Author:darcy Date: 2011-03-31 19:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/856cc9e97aea 7005628: Clarify NPE behavior of Throwable.addSuppressed(null) Reviewed-by: dholmes, mchung, jjb ! src/share/classes/java/lang/ArithmeticException.java ! s