hg: jdk8/tl/jdk: 7106773: 512 bits RSA key cannot work with SHA384 and SHA512

2012-01-12 Thread xuelei . fan
Changeset: 11e52d5ba64e Author:xuelei Date: 2012-01-12 03:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11e52d5ba64e 7106773: 512 bits RSA key cannot work with SHA384 and SHA512 Reviewed-by: weijun ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classe

hg: jdk8/tl/langtools: 7123100: javac fails with java.lang.StackOverflowError

2012-01-12 Thread maurizio . cimadamore
Changeset: 133744729455 Author:mcimadamore Date: 2012-01-12 15:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133744729455 7123100: javac fails with java.lang.StackOverflowError Summary: Inference of under-constrained type-variables creates erroneous recursive wildc

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b20 for changeset ffd294128a48

2012-01-12 Thread john . coomes
Changeset: 020819eb56d2 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/020819eb56d2 Added tag jdk8-b20 for changeset ffd294128a48 ! .hgtags

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-12 Thread Kurchi Hazra
Hi Dmitry, Thanks for your comments. Please see my doubts/comments inline : On 1/11/2012 6:34 AM, Dmitry Samersoff wrote: Kurchi, Sorry for stepping into it at later stage, my few cents. 1. Agent.java 220comments is not relevant any more. 248check of existence of configFile

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-12 Thread Dmitry Samersoff
On 2012-01-13 02:30, Kurchi Hazra wrote: >> 1. Agent.java >> >> 220comments is not relevant any more. >> >> 248check of existence of configFile is not necessary. > > Thanks, I removed these. > >> 255-258 a) Exceptions could be collapsed > > This cannot be collapsed since FileNot

Re: Webrev for 6972759

2012-01-12 Thread David Holmes
On 13/01/2012 7:39 AM, Bill Pittore wrote: Thanks for the comment. I dug up a slightly dated (refers to SCCS ) coding convention document that recommends not to put bug IDs in the comments. I'll delete it. There are numerous places in the hotspot code where comments refer to a specific CR so I

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-12 Thread David Holmes
On 13/01/2012 8:50 AM, Dmitry Samersoff wrote: On 2012-01-13 02:30, Kurchi Hazra wrote: 255-258 a) Exceptions could be collapsed This cannot be collapsed since FileNotFoundException is a subclass of IOException. Does it mean that we can simple remove catch of FileNotFoundException, replacing

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-12 Thread Mandy Chung
Dmitry, On 1/11/2012 6:34 AM, Dmitry Samersoff wrote: Kurchi, Sorry for stepping into it at later stage, my few cents. 1. Agent.java 220comments is not relevant any more. Why is it not relevant any more? Hmm this code is a bit confusing. The sun.management.snmp.AdaptorBootstra

hg: jdk8/tl/jdk: 7090565: Move test/closed/javax/security/auth/x500/X500Principal/Parse.java to open tests

2012-01-12 Thread weijun . wang
Changeset: 38bf1e9b6979 Author:weijun Date: 2012-01-13 09:50 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38bf1e9b6979 7090565: Move test/closed/javax/security/auth/x500/X500Principal/Parse.java to open tests Reviewed-by: mullan + test/javax/security/auth/x500/X500Princip

hg: jdk8/tl/jdk: 2 new changesets

2012-01-12 Thread valerie . peng
Changeset: ef3b6736c074 Author:valeriep Date: 2012-01-12 16:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef3b6736c074 7088989: Improve the performance for T4 by utilizing the newly provided crypto APIs Summary: Added the OracleUcrypto provider for utilizing the Solaris

Re: Webrev for 6972759

2012-01-12 Thread yumin . qi
Looks OK. One comment, should we include the CR in comment? I remember it should not be there. --Yumin On 1/12/2012 12:24 PM, Bill Pittore wrote: Hi David, Thanks for forwarding this to the SA list. I did run the nsk/jvmti tests from the UTE area on sqenfs-1.us.oracle.com. There were no ne

Re: Webrev for 6972759

2012-01-12 Thread Bill Pittore
Hi David, Thanks for forwarding this to the SA list. I did run the nsk/jvmti tests from the UTE area on sqenfs-1.us.oracle.com. There were no new failures with this change. bill On 1/12/2012 2:54 AM, David Holmes wrote: Hi Bill, I believe this should have gone out to the Serviceability

Re: Webrev for 6972759

2012-01-12 Thread Bill Pittore
Thanks for the comment. I dug up a slightly dated (refers to SCCS ) coding convention document that recommends not to put bug IDs in the comments. I'll delete it. thanks, bill On 1/12/2012 3:34 PM, yumin...@oracle.com wrote: Looks OK. One comment, should we include the CR in comment? I rem