Re: RFR: 7165755 OS Information much longer on linux than other platforms

2012-05-04 Thread Nils Loodin
Updated this with pulling out some shared code to os_posix.cpp. Some methods were different enough that this wasn't possible though. Do you like this better? Webrev: http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ On May 2, 2012, at 14:08 , Nils Loodin wrote: > > On May 2, 2012, at 14:0

RFR - BUG7163117: SA Agent can't connect to process on Mac OSX

2012-05-04 Thread Nils Loodin
looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ Need reviews and a sponsor! Regards, Nils Loodin

Re: RFR: 7165755 OS Information much longer on linux than other platforms

2012-05-04 Thread Dmitry Samersoff
Nils, os_bsd.cpp: 2359: // Print warning if unsafe chroot environment detected constant below is unstable_chroot_error 2373: Never heard about neither about /etc/XXX-release on BSD nor about mandrake or redhat bsd. Please fix it as well. 2409: st->print(os::Bsd::glibc_vers

Re: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX

2012-05-04 Thread Staffan Larsen
Looks good. I can sponsor the push. What kind of testing have you done? /Staffan On 4 maj 2012, at 11:28, Nils Loodin wrote: > looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using > nowadays. > > http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ > > > > Need reviews

Re: RFR: 7165755 OS Information much longer on linux than other platforms

2012-05-04 Thread Staffan Larsen
Note that there is _lots_ of old cruft in os_bsd.cpp that are leftovers from the bsd port and needs to be cleaned up. Basically the file is a copy of os_linux.cpp with things removed by #ifdefs. I don't think it is in the scope of Nils' current work to do this cleanup. /Staffan On 4 maj 2012,

Re: RFR: 7165755 OS Information much longer on linux than other platforms

2012-05-04 Thread Dmitry Samersoff
Staffan, OK. -Dmitry On 2012-05-04 14:11, Staffan Larsen wrote: > Note that there is _lots_ of old cruft in os_bsd.cpp that are leftovers from > the bsd port and needs to be cleaned up. > Basically the file is a copy of os_linux.cpp with things removed by #ifdefs. > > I don't think it is

Re: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX

2012-05-04 Thread Nils Loodin
Built it and connected to a running java process and ran some commands. I see other issues, but the connecting part actually works now. This will probably open up more bugs. /Nils Loodin On May 4, 2012, at 12:05 , Staffan Larsen wrote: > Looks good. I can sponsor the push. > > What kind of tes

RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-05-04 Thread Dmitry Samersoff
Hi Everybody, Below is slightly modified version of the fix created by Deven You. http://cr.openjdk.java.net/~dsamersoff/7164191/webrev.00/ -Dmitry On 2012-04-26 05:21, Deven You wrote: > Hi Dmitry, > > Thanks for your help. I have created a CR with internal id 2236492 which > hasn't be publi

hg: jdk8/tl/langtools: 7166010: (javac) JavacMessager incorrectly restores log source file

2012-05-04 Thread kumar . x . srinivasan
Changeset: d10db3576c08 Author:ksrini Date: 2012-05-04 07:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d10db3576c08 7166010: (javac) JavacMessager incorrectly restores log source file Reviewed-by: jjg Contributed-by: jan.lah...@oracle.com ! src/share/classes/com/s

hg: jdk8/tl/jdk: 7166598: FilteredRowSetImpl can result in Invalid Cursor Position

2012-05-04 Thread lance . andersen
Changeset: 4580652d9828 Author:lancea Date: 2012-05-04 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Reviewed-by: lancea Contributed-by: Knut Anders Hatlen ! src/share/classes/com/sun/rows

hg: jdk8/tl/jdk: 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites

2012-05-04 Thread xuelei . fan
Changeset: 41d3f7509e00 Author:xuelei Date: 2012-05-04 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d3f7509e00 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl