Re: RFR: 7161732: Improve handling of thread_id in OSThread

2012-05-07 Thread Rickard Bäckman
David, I can't find that code in any of the modified files (only as "blue" text in osThread_bsd.hpp, but that is removed code). There is a set_thread_id in osThread.hpp 118 void set_thread_id(thread_id_t id) { _thread_id = id; } Thanks /R On 05/06/2012 02:10 PM, David Holmes

Re: RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-05-07 Thread Staffan Larsen
Looks good! /Staffan On 4 maj 2012, at 14:31, Dmitry Samersoff wrote: > Hi Everybody, > > Below is slightly modified version of the fix created by Deven You. > > http://cr.openjdk.java.net/~dsamersoff/7164191/webrev.00/ > > -Dmitry > > > On 2012-04-26 05:21, Deven You wrote: >> Hi Dmitry, >

hg: jdk8/tl/jdk: 7166048: Remove the embeded epoll data structure.

2012-05-07 Thread littlee
Changeset: 62557a1336c0 Author:zhouyx Date: 2012-05-07 16:43 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62557a1336c0 7166048: Remove the embeded epoll data structure. Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c

Re: RFR: 7161732: Improve handling of thread_id in OSThread

2012-05-07 Thread David Holmes
On 7/05/2012 5:21 PM, Rickard Bäckman wrote: David, I can't find that code in any of the modified files (only as "blue" text in osThread_bsd.hpp, but that is removed code). Sorry the frames view of the webrev confused me. It is "blue" but that is normally added or modified code, while "red" i

Re: RFR: 7161732: Improve handling of thread_id in OSThread

2012-05-07 Thread Rickard Bäckman
On 05/07/2012 10:55 AM, David Holmes wrote: On 7/05/2012 5:21 PM, Rickard Bäckman wrote: David, I can't find that code in any of the modified files (only as "blue" text in osThread_bsd.hpp, but that is removed code). Sorry the frames view of the webrev confused me. It is "blue" but that is no

hg: jdk8/tl/jdk: 7166687: InetAddress.getLocalHost().getHostName() returns FQDN

2012-05-07 Thread rob . mckenna
Changeset: b26c04717735 Author:robm Date: 2012-05-07 13:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Reviewed-by: chegar ! src/solaris/native/java/net/Inet6AddressImpl.c

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-05-07 Thread Artem Ananiev
Hi, Mandy, the client part of the fix looks fine. Let me ask a naive question, though. From your explanation, I see that System.loadLibrary() is now aware of modules. What prevents us to change LoadLibraryAction the same way? "FROM" code looks much more elegant than the new (the old?) "TO" one

Re: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt

2012-05-07 Thread Jonathan Lu
Thanks a lot, Alan. I'll go to serviceability-dev list for further discussion. Best regards! - Jonathan Lu On 05/02/2012 04:36 PM, Alan Bateman wrote: On 02/05/2012 09:27, Jonathan Lu wrote: Hi build-dev, I've got a minor change to fix an invalid path from README.txt of MemoryMonitor demo,

Re: RFR: 7165755 OS Information much longer on linux than other platforms

2012-05-07 Thread David Holmes
On 4/05/2012 6:26 PM, Nils Loodin wrote: Updated this with pulling out some shared code to os_posix.cpp. Some methods were different enough that this wasn't possible though. Do you like this better? Webrev: http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ I don't see any os_posix.cpp ch