Excess threads reporting on deadlock

Hi, I would like to propose a patch regarding deadlock detection. Excess threads reporting on deadlock http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6850341 https://bugs.openjdk.java.net/show_bug.cgi?id=100065 Deadlock detection mechanism (ThreadMXBean.findMonitorDeadlockedThreads() and Th

Re: Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Thanks David for the review. On 11/26/2012 9:38 PM, David Holmes wrote: Hi Bill, A few minor comments, some of which you've touched on with Dmitry. David -- share/back/debugInit.c 40 #include "sys.h" Shouldn't that be ? No, it's really "sys.h" -> jdk/src/share/back/export/sys.h:

Deadlock detection mechanism incorrectly assumes that thread cannot block itself

Hi, One more patch regarding deadlock detection. https://bugs.openjdk.java.net/show_bug.cgi?id=100059 Deadlock detection mechanism assumes that thread cannot block itself. In general this is not right, especially in case of non-reentrant mutexes. One of such examples we can find here (FIFOMute

hg: jdk8/tl/jdk: 8003833: Spurious NPE from Socket.getIn/OutputStream

Changeset: ddf97baea570 Author:chegar Date: 2012-11-27 17:15 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddf97baea570 8003833: Spurious NPE from Socket.getIn/OutputStream Reviewed-by: alanb, dsamersoff ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/

hg: jdk8/tl/langtools: 8004068: Fix build problems caused by on-demand imports

Changeset: 4d68e2a05b50 Author:jjg Date: 2012-11-27 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d68e2a05b50 8004068: Fix build problems caused by on-demand imports Reviewed-by: jjg Contributed-by: eric.casp...@amd.com ! src/share/classes/com/sun/tools/javac/c

hg: jdk8/tl/jdk: 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests

Changeset: 40311b5f478f Author:robm Date: 2012-11-28 00:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40311b5f478f 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests Reviewed-by: chegar + test/java/net/ResponseCache/Test.java + test/java/net/Socket/

Re: Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Thanks Bill - Reviewed. David On 28/11/2012 1:49 AM, BILL PITTORE wrote: Thanks David for the review. On 11/26/2012 9:38 PM, David Holmes wrote: Hi Bill, A few minor comments, some of which you've touched on with Dmitry. David -- share/back/debugInit.c 40 #include "sys.h" Shouldn't

Re: Deadlock detection mechanism incorrectly assumes that thread cannot block itself

On 28/11/2012 2:10 AM, Dmytro Sheyko wrote: Hi, One more patch regarding deadlock detection. https://bugs.openjdk.java.net/show_bug.cgi?id=100059 Deadlock detection mechanism assumes that thread cannot block itself. In general this is not right, especially in case of non-reentrant mutexes. Ar

Re: Deadlock detection mechanism incorrectly assumes that thread cannot block itself

Thinking more on this ... it is a self-deadlock if a thread is blocked on an AbstractOwnableSynchronizer and the owner is that thread. That won't catch everything though - eg non-reentrant RWL and you tried to upgrade from RL to WL. David On 28/11/2012 12:53 PM, David Holmes wrote: On 28/11/

hg: jdk8/tl/jdk: 8004088: hg push for bug#4235519 failed to push all files

Changeset: c6ed2c238d4f Author:sherman Date: 2012-11-27 22:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6ed2c238d4f 8004088: hg push for bug#4235519 failed to push all files Summary: pushed all base64 files Reviewed-by: alanb, mduigou + src/share/classes/java/util/Base

hg: hsx/hotspot-rt/hotspot: 8003879: Duplicate definitions in vmStructs

Changeset: 7c15faa95ce7 Author:mikael Date: 2012-11-27 07:57 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7c15faa95ce7 8003879: Duplicate definitions in vmStructs Summary: Removed duplicate entries Reviewed-by: dholmes, sspitsyn ! src/share/vm/gc_implementation/