[PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2012-12-31 Thread Jaroslav Bachorik
Looking for a review and a sponsor. Webrev at: http://cr.openjdk.java.net/~jbachorik/8005472/webrev.00/test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh.sdiff.html JPRT run on windows targets: http://sthjprt.se.oracle.com/archives/2012/12/2012-12-28-123054.jbachorik

Re: RFR (S): 8004747: Remove last_entry from VM_STRUCT macros

2012-12-31 Thread serguei.spit...@oracle.com
Mikael, It looks good. It is also a nice simplification! The only thing I'd suggest is to be more specific in the assert at the end of the vmStructs.cpp. Instead of "Incorrect last entry" it'd be better to have "Incorrect struct last entry", etc. Also, it'd be useful if Yumin had a chance to

Re: RFR (S): 8004747: Remove last_entry from VM_STRUCT macros

2012-12-31 Thread Yumin Qi
Looks good. Thanks for the fix, the macros is quite complex to understand. Agree with Serguei the assertion with better description. Thanks Yumin On 12/31/2012 10:36 AM, serguei.spit...@oracle.com wrote: Mikael, It looks good. It is also a nice simplification! The only thing I'd suggest is t