Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

I still have no idea why the test failed, but I do not see why a longer timeout can fix the test. Have you reproduced the problem and tested your fix? if yes then possible the long timeout hided a real problem. The timeout you made longer was used to wait a notification which should never arri

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

On 01/09/2013 09:40 AM, shanliang wrote: > I still have no idea why the test failed, but I do not see why a longer > timeout can fix the test. Have you reproduced the problem and tested > your fix? if yes then possible the long timeout hided a real problem. Yes, I can reproduce the problem (using

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

Jaroslav Bachorik wrote: On 01/09/2013 09:40 AM, shanliang wrote: I still have no idea why the test failed, but I do not see why a longer timeout can fix the test. Have you reproduced the problem and tested your fix? if yes then possible the long timeout hided a real problem. Yes, I ca

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

On 01/09/2013 11:08 AM, shanliang wrote: > Jaroslav Bachorik wrote: >> On 01/09/2013 09:40 AM, shanliang wrote: >> >>> I still have no idea why the test failed, but I do not see why a longer >>> timeout can fix the test. Have you reproduced the problem and tested >>> your fix? if yes then possibl

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

Let's forget the JMX implementation at first. If an MBean is unregistered, a user at client side calls "removeNotificationListener" on the MBean, what should happen? if the user calls "isRegistered" on the MBean, what should happen? I have done 2 tests, I used only one thread: 1) .. local

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

On 01/09/2013 02:44 PM, shanliang wrote: > Let's forget the JMX implementation at first. If an MBean is > unregistered, a user at client side calls "removeNotificationListener" > on the MBean, what should happen? if the user calls "isRegistered" on > the MBean, what should happen? > > I have done

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

Jaroslav Bachorik wrote: On 01/09/2013 02:44 PM, shanliang wrote: Let's forget the JMX implementation at first. If an MBean is unregistered, a user at client side calls "removeNotificationListener" on the MBean, what should happen? if the user calls "isRegistered" on the MBean, what should ha

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

shanliang wrote: I think we have 3 things to do here: 1) modify the test to not use removeNotificationListener for testing listener leak 2) create a new bug about a client does not throw an exception after an mbean is unregistered 3) create a bug about a client does not throw a same exception a

Re: RFR JDK-8005120

On 08/01/2013 21:32, John Zavgren wrote: On 12/28/2012 10:49 AM, John Zavgren wrote: Please consider the following webrev for JDK-8005120. http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/webrev.06/ I don't se

hg: jdk8/tl/jdk: 3 new changesets

Changeset: 86828e84654f Author:mullan Date: 2013-01-08 19:00 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86828e84654f 7019834: Eliminate dependency from PolicyFile to com.sun.security.auth.PrincipalComparator Summary: Add new java.security.Principal.implies method Reviewe

Re: request for review - 8004172: Remove display of permanent generation counters from jstat options

I still need a review from an official "reviewer" please. Jon On 1/4/2013 2:41 PM, Jon Masamitsu wrote: 8004172: Remove display of permanent generation counters from jstat options This change removes from the jstat options the display of permanent generation counters. It also removes entir

hg: hsx/hotspot-rt/hotspot: 8005689: InterfaceAccessFlagsTest failures in Lambda-JDK tests

Changeset: adc176e95bf2 Author:acorn Date: 2013-01-09 11:39 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/adc176e95bf2 8005689: InterfaceAccessFlagsTest failures in Lambda-JDK tests Summary: Fix verifier for new interface access flags Reviewed-by: acorn, kvn Contr

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: dd7248d3e151 Author:zgu Date: 2013-01-09 14:46 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dd7248d3e151 7152671: RFE: Windows decoder should add some std dirs to the symbol search path Summary: Added JRE/JDK bin directories to decoder's symbol search

hg: jdk8/tl/jdk: 7103957: NegativeArraySizeException while initializing class IntegerCache

Changeset: 4c8b37f159f9 Author:mchung Date: 2013-01-09 16:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c8b37f159f9 7103957: NegativeArraySizeException while initializing class IntegerCache Reviewed-by: darcy, mchung Contributed-by: brian.burkhal...@oracle.com ! src/sha

hg: jdk8/tl/langtools: 8004730: Add language model support for parameter reflection

Changeset: 7612fe48be90 Author:darcy Date: 2013-01-09 20:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7612fe48be90 8004730: Add language model support for parameter reflection Reviewed-by: abuckley ! src/share/classes/javax/lang/model/element/Element.java ! src/sh

hg: jdk8/tl/jdk: 8005713: Simplify library support for repeating annotations in java.lang.annotation

Changeset: 4176e6cc499e Author:darcy Date: 2013-01-09 20:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4176e6cc499e 8005713: Simplify library support for repeating annotations in java.lang.annotation Reviewed-by: abuckley + src/share/classes/java/lang/annotation/Repeata