Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-15 Thread Rickard Bäckman
John, thanks for the review. I move the entry_frame_is_first(…) to JavaCallWrapper and named it is_first_frame(). Updated webrev: http://cr.openjdk.java.net/~rbackman/8016131.u1/ Thanks /R On Jul 13, 2013, at 12:15 AM, John Rose wrote: > It's good. > > One comment: The new overloading of aux

RFR: 8019584 javax/management/remote/mandatory/loading/MissingClassTest.java failed in nightly against jdk7u45: java.io.InvalidObjectException: Invalid notification: null

2013-07-15 Thread Jaroslav Bachorik
Please, review the patch for https://jbs.oracle.com/bugs/browse/JDK-8019584 http://cr.openjdk.java.net/~jbachorik/8019584/webrev.00/ The reason for the failure is that the ObjectInputStream.readFields() method does not throw CNFE as specified when encountering instances of unknown in the object g

hg: jdk8/tl/jdk: 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations

2013-07-15 Thread joel . franck
Changeset: e4ce6502eac0 Author:plevart Date: 2013-07-15 10:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4ce6502eac0 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations Reviewed-by: dholmes, jfranck ! src/share/classes/java/lang/Class.java ! src

hg: hsx/hotspot-rt/hotspot: 17 new changesets

2013-07-15 Thread frederic . parain
Changeset: e50be1620201 Author:goetz Date: 2013-07-08 14:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e50be1620201 8020059: The flag introduced by 8014972 is not defined if Hotspot is built without a compiler (zero, ppc64 core build). Summary: define CodeCac

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-07-15 Thread rickard . backman
Changeset: 23123fc6968a Author:rbackman Date: 2013-07-15 11:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/23123fc6968a 8019324: assert(_f2 == 0 || _f2 == f2) failed: illegal field change Reviewed-by: dholmes, rbackman Contributed-by: David Simms ! src/share/v

hg: jdk8/tl/jdk: 8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl

2013-07-15 Thread sean . coffey
Changeset: 7cc35dd1885d Author:coffeys Date: 2013-07-15 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cc35dd1885d 8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl Reviewed-by: mchung ! src/share/lib/security/java.security-linux ! src/shar

Re: jmx-dev RFR: 8019584 javax/management/remote/mandatory/loading/MissingClassTest.java failed in nightly against jdk7u45: java.io.InvalidObjectException: Invalid notification: null

2013-07-15 Thread Daniel Fuchs
Hi Jaroslav, This looks reasonable. I assume you have run the JCK to verify that it doesn't break anything else? best regards, -- daniel On 7/11/13 1:48 PM, Jaroslav Bachorik wrote: Please, review the change. http://cr.openjdk.java.net/~jbachorik/8019584/webrev.00/ The combination of the fi

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-15 Thread Vladimir Kozlov
Hi, Rickard There are several methods already in Thread class which do similar address cheacks: on_local_stackO, is_in_stack(). It would be nice to have new check (at least part of it) at the same place. What about closed changes for entry_frame_call_wrapper_addr()? Thanks, Vladimir On 7/14/

Re: Request for review:8020309:Remove InstanceKlass::_cached_class_file_len and record the length together with the cached class file bytes

2013-07-15 Thread serguei.spit...@oracle.com
Hi Jiangli, It looks good, thank you for the update! It makes sense to also run the JTREG java/lang/instrument tests. Thanks, Serguei On 7/12/13 1:55 PM, Jiangli Zhou wrote: Hi Ioi and Serguei, Here is the updated the webrev: http://cr.openjdk.java.net/~jiangli/8020309/webrev.01/. I've rete

Re: Request for review:8020309:Remove InstanceKlass::_cached_class_file_len and record the length together with the cached class file bytes

2013-07-15 Thread Jiangli Zhou
Hi Serguei, Thanks for the review! I've rerun all following tests and JPTR: jdk/test/java/lang/instrument jdk/test/com/sun/jdi nsk.jvmti nsk.jdi nsk.hprof Thanks, Jiangli On 07/15/2013 01:07 PM, serguei.spit...@oracle.com wrote: Hi Jiangli, It looks good, thank you for th

Re: Request for review:8020309:Remove InstanceKlass::_cached_class_file_len and record the length together with the cached class file bytes

2013-07-15 Thread Jiangli Zhou
On 07/15/2013 01:58 PM, Jiangli Zhou wrote: Hi Serguei, Thanks for the review! I've rerun all following tests and JPTR: jdk/test/java/lang/instrument jdk/test/com/sun/jdi nsk.jvmti nsk.jdi nsk.hprof And vm.quick.testlist as well. Thanks, Jiangli Thanks, Jiangli On 07/1

Re: Request for review:8020309:Remove InstanceKlass::_cached_class_file_len and record the length together with the cached class file bytes

2013-07-15 Thread Ioi Lam
Looks good to me. Thanks - Ioi On 07/12/2013 01:55 PM, Jiangli Zhou wrote: Hi Ioi and Serguei, Here is the updated the webrev: http://cr.openjdk.java.net/~jiangli/8020309/webrev.01/. I've retested with nsk.jvmti, nsk.jdi and nsk.hprof. I'm rerunning the JPRT and rest of the tests. Thanks,

Re: Request for review:8020309:Remove InstanceKlass::_cached_class_file_len and record the length together with the cached class file bytes

2013-07-15 Thread Jiangli Zhou
Thanks, Ioi! Jiangli On 07/15/2013 03:05 PM, Ioi Lam wrote: Looks good to me. Thanks - Ioi On 07/12/2013 01:55 PM, Jiangli Zhou wrote: Hi Ioi and Serguei, Here is the updated the webrev: http://cr.openjdk.java.net/~jiangli/8020309/webrev.01/. I've retested with nsk.jvmti, nsk.jdi and nsk.h

Re: Request for review:8020309:Remove InstanceKlass::_cached_class_file_len and record the length together with the cached class file bytes

2013-07-15 Thread Daniel D. Daugherty
On 7/12/13 2:55 PM, Jiangli Zhou wrote: Hi Ioi and Serguei, Here is the updated the webrev: http://cr.openjdk.java.net/~jiangli/8020309/webrev.01/. Thumbs up! src/share/vm/classfile/classFileParser.cpp nit line 3960: &ptr, &end_ptr, nit line 3961: &cached_class_file); Now tha

Re: Request for review:8020309:Remove InstanceKlass::_cached_class_file_len and record the length together with the cached class file bytes

2013-07-15 Thread Jiangli Zhou
Hi Dan, Thanks for the review! On 07/15/2013 03:45 PM, Daniel D. Daugherty wrote: On 7/12/13 2:55 PM, Jiangli Zhou wrote: Hi Ioi and Serguei, Here is the updated the webrev: http://cr.openjdk.java.net/~jiangli/8020309/webrev.01/. Thumbs up! src/share/vm/classfile/classFileParser.cpp n

Re: RFR: 8019584 javax/management/remote/mandatory/loading/MissingClassTest.java failed in nightly against jdk7u45: java.io.InvalidObjectException: Invalid notification: null

2013-07-15 Thread David Holmes
On 15/07/2013 6:41 PM, Jaroslav Bachorik wrote: Please, review the patch for https://jbs.oracle.com/bugs/browse/JDK-8019584 http://cr.openjdk.java.net/~jbachorik/8019584/webrev.00/ The reason for the failure is that the ObjectInputStream.readFields() method does not throw CNFE as specified when

hg: jdk8/tl/jdk: 8020409: Clean up doclint problems in java.util package, part 1

2013-07-15 Thread joe . darcy
Changeset: 94e1a4b10811 Author:bpb Date: 2013-07-15 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94e1a4b10811 8020409: Clean up doclint problems in java.util package, part 1 Summary: Clean up doclint problems in java.util package, part 1 Reviewed-by: darcy Contributed

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-15 Thread John Rose
On Jul 15, 2013, at 9:59 AM, Vladimir Kozlov wrote: > There are several methods already in Thread class which do similar address > cheacks: on_local_stackO, is_in_stack(). It would be nice to have new check > (at least part of it) at the same place. Yes, that's a good idea! Thread::is_in_usab

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-15 Thread Rickard Bäckman
Vladimir & John, thanks for the suggestion. It makes sense. Updated webrev: http://cr.openjdk.java.net/~rbackman/8016131.u2/ Thanks /R On Jul 16, 2013, at 4:26 AM, John Rose wrote: > On Jul 15, 2013, at 9:59 AM, Vladimir Kozlov > wrote: > >> There are several methods already in Thread class

hg: jdk8/tl/nashorn: 7 new changesets

2013-07-15 Thread sundararajan . athijegannathan
Changeset: 973d78ee0728 Author:attila Date: 2013-07-15 12:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/973d78ee0728 8020324: Implement Object.bindProperties(target, source) for beans Reviewed-by: hannesw, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.j

hg: hsx/hotspot-rt/hotspot: 8015759: hotspot changes needed to compile with Visual Studio 2012

2013-07-15 Thread david . holmes
Changeset: 33c52908bcdb Author:dholmes Date: 2013-07-15 23:23 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/33c52908bcdb 8015759: hotspot changes needed to compile with Visual Studio 2012 Reviewed-by: anthony, dholmes, dcubed Contributed-by: Tim Bell ! make/wind

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-15 Thread John Rose
Good. — John On Jul 15, 2013, at 10:11 PM, Rickard Bäckman wrote: > thanks for the suggestion. It makes sense. > Updated webrev: http://cr.openjdk.java.net/~rbackman/8016131.u2/

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-15 Thread Rickard Bäckman
Thank you! /R On Jul 16, 2013, at 8:24 AM, John Rose wrote: > Good. — John > > On Jul 15, 2013, at 10:11 PM, Rickard Bäckman > wrote: > >> thanks for the suggestion. It makes sense. >> Updated webrev: http://cr.openjdk.java.net/~rbackman/8016131.u2/ >

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-15 Thread Vladimir Kozlov
Rickard, One thing is_in_stack() has is check _stack_base == NULL. In your case it may not happen then you need to add assert to make sure it really does not happen. Or use stack_base() method which has the assert. Thanks, Vladimir On 7/15/13 10:11 PM, Rickard Bäckman wrote: Vladimir & John,