hg: jdk8/tl/jdk: 8023529: OpenMBeanInfoSupport.equals/hashCode throw NPE

2013-09-12 Thread shanliang . jiang
Changeset: e407df8093dc Author:sjiang Date: 2013-09-12 09:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e407df8093dc 8023529: OpenMBeanInfoSupport.equals/hashCode throw NPE Reviewed-by: dholmes, dfuchs ! src/share/classes/javax/management/openmbean/OpenMBeanInfoSupport.j

Re: RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread Chris Hegarty
On 09/12/2013 04:45 AM, David Holmes wrote: Hi Jaroslav, You need a copyright notice in the new file. As written this test can only run on a full JDK - so please add it to the :needs_jdk group in TEST.groups. (Does jcmd really needs to come from the test-jdk? And use the VMOPTS passed to the te

Re: RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread Jaroslav Bachorik
On 09/12/2013 10:12 AM, Chris Hegarty wrote: > On 09/12/2013 04:45 AM, David Holmes wrote: >> Hi Jaroslav, >> >> You need a copyright notice in the new file. >> >> As written this test can only run on a full JDK - so please add it to >> the :needs_jdk group in TEST.groups. (Does jcmd really needs t

hg: jdk8/tl/jdk: 8024643: Turn on javac lint checking in building the jdk repo

2013-09-12 Thread joe . darcy
Changeset: 262a625809fd Author:darcy Date: 2013-09-12 01:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/262a625809fd 8024643: Turn on javac lint checking in building the jdk repo Reviewed-by: erikj, ihse, smarks ! makefiles/Setup.gmk

Re: RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread David Holmes
On 12/09/2013 6:12 PM, Chris Hegarty wrote: On 09/12/2013 04:45 AM, David Holmes wrote: Hi Jaroslav, You need a copyright notice in the new file. As written this test can only run on a full JDK - so please add it to the :needs_jdk group in TEST.groups. (Does jcmd really needs to come from the

testlibrary (was Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out)

2013-09-12 Thread Dmitry Samersoff
Chris, Does I understand correctly that we have two independent copy of testlibrary - one in hotspot workspace and other one in jdk workspace? -Dmitry On 2013-09-12 12:12, Chris Hegarty wrote: > On 09/12/2013 04:45 AM, David Holmes wrote: >> Hi Jaroslav, >> >> You need a copyright notice in the

Re: testlibrary (was Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out)

2013-09-12 Thread Chris Hegarty
On 09/12/2013 12:43 PM, Dmitry Samersoff wrote: Chris, Does I understand correctly that we have two independent copy of testlibrary - one in hotspot workspace and other one in jdk workspace? Unfortunately, I believe that is the case. Are you seeing differences between them? -Chris. -Dmitr

Re: testlibrary (was Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out)

2013-09-12 Thread David Holmes
On 12/09/2013 9:48 PM, Chris Hegarty wrote: On 09/12/2013 12:43 PM, Dmitry Samersoff wrote: Chris, Does I understand correctly that we have two independent copy of testlibrary - one in hotspot workspace and other one in jdk workspace? Unfortunately, I believe that is the case. Are you seeing

Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread Jaroslav Bachorik
On 09/12/2013 10:22 AM, Jaroslav Bachorik wrote: > On 09/12/2013 10:12 AM, Chris Hegarty wrote: >> On 09/12/2013 04:45 AM, David Holmes wrote: >>> Hi Jaroslav, >>> >>> You need a copyright notice in the new file. >>> >>> As written this test can only run on a full JDK - so please add it to >>> the

hg: hsx/hotspot-rt/hotspot: 8022617: Openjdk hotspot build is broken on BSD platforms using gcc

2013-09-12 Thread dmitry . samersoff
Changeset: 1c6b721a3fbf Author:dsamersoff Date: 2013-09-12 15:53 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1c6b721a3fbf 8022617: Openjdk hotspot build is broken on BSD platforms using gcc Summary: Enforce of preprocessing of all assembly sources by assembler-w

Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread Dmitry Samersoff
Jaroslav, CustomLauncherTest.java: 102: this check could be moved to switch at ll. 108 otherwise test fails on "sunos" and "linux" because PLATFORM remains unset. 129: I would prefer don't have pattern like this one ever in shell script. Could you prepare a list of VM's to check and just loop ov

hg: jdk8/tl/jdk: 8024525: Make Logger log methods call isLoggable()

2013-09-12 Thread daniel . fuchs
Changeset: 631c8dcd91f4 Author:dfuchs Date: 2013-09-12 17:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/631c8dcd91f4 8024525: Make Logger log methods call isLoggable() Summary: This changeset makes the various Logger logging method call isLoggable() instead of inlining t

Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread Jaroslav Bachorik
On 09/12/2013 05:13 PM, Dmitry Samersoff wrote: > Jaroslav, > > CustomLauncherTest.java: > > 102: this check could be moved to switch at ll. 108 > otherwise test fails on "sunos" and "linux" because PLATFORM remains unset. Good idea. Thanks. > > 129: I would prefer don't have pattern like this

Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread Dmitry Samersoff
Jaroslav, I'm not sure that replacing 50 lines shell script with 250 lines Java program we should keep it close to original. ;) -Dmitry On 2013-09-12 19:31, Jaroslav Bachorik wrote: > On 09/12/2013 05:13 PM, Dmitry Samersoff wrote: >> Jaroslav, >> >> CustomLauncherTest.java: >> >> 102: this che

Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

2013-09-12 Thread Jaroslav Bachorik
On 09/12/2013 05:53 PM, Dmitry Samersoff wrote: > Jaroslav, > > I'm not sure that replacing 50 lines shell script with 250 lines Java > program we should keep it close to original. ;) Well, I've deliberately dropped the intermittent failure generator ;) And it's 150 against 250 ... What I meant

hg: jdk8/tl/jdk: 8024618: Issues with French locale on compact1, 2: expected: but was:

2013-09-12 Thread roger . riggs
Changeset: 672f349fbad7 Author:rriggs Date: 2013-09-12 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/672f349fbad7 8024618: Issues with French locale on compact1,2: expected: but was: Summary: Tests against the data of the French locale are not valid as conformance te

hg: jdk8/tl/jdk: 8015340: remove erroneous @since tag

2013-09-12 Thread lance . andersen
Changeset: 60d6f60416ca Author:lancea Date: 2013-09-12 13:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d6f60416ca 8015340: remove erroneous @since tag Reviewed-by: darcy ! src/share/classes/java/sql/PreparedStatement.java

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread serguei.spit...@oracle.com
On 9/11/13 8:58 PM, David Holmes wrote: On 12/09/2013 1:54 PM, David Holmes wrote: Hi Dmitry, Sorry Serguei. I'm Ok. :) Thank you for review! Thanks, Serguei David It seems odd that you install the new_method even if there was an exception. What if the new_method is not valid because o

hg: jdk8/tl/langtools: 8013846: javac fails to reject semantically equivalent generic method declarations

2013-09-12 Thread eric . mccorkle
Changeset: 5d2d484a1216 Author:emc Date: 2013-09-12 14:52 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5d2d484a1216 8013846: javac fails to reject semantically equivalent generic method declarations Summary: Cause javac to consider intersection types with the same el

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread serguei.spit...@oracle.com
On 9/11/13 8:54 PM, David Holmes wrote: Hi Dmitry, It seems odd that you install the new_method even if there was an exception. What if the new_method is not valid because of the exception ? Coleen suggested this fragment. New methods will be deallocated with the scratch class in a case of e

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread serguei.spit...@oracle.com
On 9/12/13 12:58 PM, Stefan Karlsson wrote: On 9/12/13 9:21 PM, serguei.spit...@oracle.com wrote: On 9/11/13 8:54 PM, David Holmes wrote: Hi Dmitry, It seems odd that you install the new_method even if there was an exception. What if the new_method is not valid because of the exception ? C

hg: jdk8/tl/jdk: 8011916: Spec update for java.util.stream; ...

2013-09-12 Thread henry . jen
Changeset: be6f5f027bc2 Author:henryjen Date: 2013-09-06 22:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be6f5f027bc2 8011916: Spec update for java.util.stream 8024339: j.u.s.Stream.reduce(BinaryOperator) throws unexpected NPE Reviewed-by: mduigou Contributed-by: brian.g

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread Stefan Karlsson
On 9/12/13 9:21 PM, serguei.spit...@oracle.com wrote: On 9/11/13 8:54 PM, David Holmes wrote: Hi Dmitry, It seems odd that you install the new_method even if there was an exception. What if the new_method is not valid because of the exception ? Coleen suggested this fragment. New methods wi

Re: Code review request for Linux version id fix (6986195)

2013-09-12 Thread Omair Majid
Hi, On 09/12/2013 04:00 PM, Daniel D. Daugherty wrote: > The "lsb-release" file is the new Linux standard so it is now in the list. > I also added the "system-release" and "os-release" files since they are > an old standard. Actually, /etc/os-release is a fairly new thing [1] that is required by

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

2013-09-12 Thread serguei.spit...@oracle.com
On 9/11/13 9:04 PM, David Holmes wrote: Hi Serguei, Typo: 2489 // scratch_cp is a merged constant po/ ol Fixed, thanks! In VM_RedefineClasses::set_new_constant_pool do you not need to de-allocate smaller_cp if you return due to an exception here: 2504 scratch_cp->copy_cp_to(1, scra

Re: Code review request for Linux version id fix (6986195)

2013-09-12 Thread Daniel D. Daugherty
> http://cr.openjdk.java.net/~dcubed/for_gthornbr/6986195-webrev/ src/os/linux/vm/os_linux.cpp No comments. Thumbs up. Just for the record, the internal review team was: dcubed dsamersoff coleenp iklam Dan On 9/12/13 2:00 PM, Daniel D. Daugherty wrote: Greetings, I am

Code review request for Linux version id fix (6986195)

2013-09-12 Thread Daniel D. Daugherty
Greetings, I am sponsoring the following code review for Jerry Thornbrugh. Since this code review request is going to two aliases, please make sure you include BOTH aliases in your replies. Dan OpenJDK bug: 6986195 correctly identify Ubuntu as the operating system in crash rep

Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

2013-09-12 Thread serguei.spit...@oracle.com
On 9/11/13 9:09 PM, David Holmes wrote: Hi Serguei, This is more consistent with the surrounding code, but: 1. Why no RC_TRACE_WITH_THREAD for this case? Ok, I'll add tracing code. 2. If an exception is pending, that isn't OOME, shouldn't "res" already not be JVMTI_ERROR_NONE and so res s

hg: jdk8/tl/langtools: 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case

2013-09-12 Thread vicente . romero
Changeset: 3ae1814f7c59 Author:vromero Date: 2013-09-12 22:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae1814f7c59 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com,

Re: RR(S): JDK-8009213 sun/management/jdp/JdpTest.sh fails with exit code 1

2013-09-12 Thread Dmitry Samersoff
Forgot to include webrev link. Sorry! http://cr.openjdk.java.net/~dsamersoff/JDK-8009213/webrev.01/ On 2013-09-11 17:15, Dmitry Samersoff wrote: > Please, review shell script changes. > > Problem: > > Sometimes, server process JVM start slowly than client process jvm, so > test can't get serv

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b107 for changeset d6a32e3831aa

2013-09-12 Thread john . coomes
Changeset: 8ade3eed63da Author:cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/8ade3eed63da Added tag jdk8-b107 for changeset d6a32e3831aa ! .hgtags

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b107 for changeset e3c9328f7563

2013-09-12 Thread john . coomes
Changeset: d1ea68556fd7 Author:cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/d1ea68556fd7 Added tag jdk8-b107 for changeset e3c9328f7563 ! .hgtags

hg: hsx/hotspot-rt: 2 new changesets

2013-09-12 Thread john . coomes
Changeset: 0874bb4707b7 Author:omajid Date: 2013-09-11 12:08 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/0874bb4707b7 8024320: Add s390(x) detection to platform.m4 Reviewed-by: erikj, ihse, dsamersoff ! common/autoconf/generated-configure.sh ! common/autoconf/platform.

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b107 for changeset 3f274927ec18

2013-09-12 Thread john . coomes
Changeset: 1b7f5a27c4ba Author:cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1b7f5a27c4ba Added tag jdk8-b107 for changeset 3f274927ec18 ! .hgtags

hg: hsx/hotspot-rt/corba: Added tag jdk8-b107 for changeset 23fc34133152

2013-09-12 Thread john . coomes
Changeset: 260f00a95705 Author:cl Date: 2013-09-12 11:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/260f00a95705 Added tag jdk8-b107 for changeset 23fc34133152 ! .hgtags

hg: hsx/hotspot-rt/jdk: 2 new changesets

2013-09-12 Thread john . coomes
Changeset: eea685b9ccaa Author:amurillo Date: 2013-09-10 05:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eea685b9ccaa 8024515: ProblemList.txt updates to exclude tests that fail with hs25-b49 Reviewed-by: alanb, chegar ! test/ProblemList.txt Changeset: b67c8099b

hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b107 for changeset f35e1255024b

2013-09-12 Thread john . coomes
Changeset: a1f980cc1355 Author:cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a1f980cc1355 Added tag jdk8-b107 for changeset f35e1255024b ! .hgtags

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

2013-09-12 Thread serguei.spit...@oracle.com
The updated webrev: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 2:35 PM, serguei.spit...@oracle.com wrote: On 9/11/13 9:04 PM, David Holmes wrote: Hi Serguei, Typo: 2489 // scratch_cp is a merged constant po/ ol Fixe

Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

2013-09-12 Thread serguei.spit...@oracle.com
The updated open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 1:03 PM, serguei.spit...@oracle.com wrote: On 9/11/13 9:09 PM, David Holmes wrote: Hi Serguei, This is more consistent with the surrounding code, but: 1. Why no

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

2013-09-12 Thread serguei.spit...@oracle.com
The update open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 5:13 PM, serguei.spit...@oracle.com wrote: The updated webrev: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/ Thanks, S

Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

2013-09-12 Thread Coleen Phillmore
This looks good. Coleen On 9/12/2013 8:21 PM, serguei.spit...@oracle.com wrote: The updated open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 1:03 PM, serguei.spit...@oracle.com wrote: On 9/11/13 9:09 PM, David Holmes wr

Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

2013-09-12 Thread serguei.spit...@oracle.com
Thank you, Coleen! Serguei On 9/12/13 5:47 PM, Coleen Phillmore wrote: This looks good. Coleen On 9/12/2013 8:21 PM, serguei.spit...@oracle.com wrote: The updated open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 1:03 P

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

2013-09-12 Thread Coleen Phillmore
This looks good too. Thanks for catching the smaller_cp case. Coleen On 9/12/2013 8:19 PM, serguei.spit...@oracle.com wrote: The update open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 5:13 PM, serguei.spit...@oracle

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

2013-09-12 Thread serguei.spit...@oracle.com
Thanks! Serguei On 9/12/13 5:52 PM, Coleen Phillmore wrote: This looks good too. Thanks for catching the smaller_cp case. Coleen On 9/12/2013 8:19 PM, serguei.spit...@oracle.com wrote: The update open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread Coleen Phillmore
It took me a while to remember why this change is the way it is. Why do you clear the pending exception at line 1601? thanks, Coleen On 9/12/2013 3:21 PM, serguei.spit...@oracle.com wrote: On 9/11/13 8:54 PM, David Holmes wrote: Hi Dmitry, It seems odd that you install the new_method even i

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread Coleen Phillmore
I see the answer to my question in the mail that hasn't come out yet. The error handling in this code relies on boolean returns in order to throw a JVMTI_ERROR code. Maybe a comment to this effect would be good above CLEAR_PENDING_EXCEPTION. I don't need to rereview this.understand that

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread serguei.spit...@oracle.com
On 9/12/13 6:22 PM, Coleen Phillmore wrote: I see the answer to my question in the mail that hasn't come out yet. The error handling in this code relies on boolean returns in order to throw a JVMTI_ERROR code. Maybe a comment to this effect would be good above CLEAR_PENDING_EXCEPTION. I

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-12 Thread serguei.spit...@oracle.com
I believe, you found the answer to this in your next email. Thanks, Serguei On 9/12/13 6:10 PM, Coleen Phillmore wrote: It took me a while to remember why this change is the way it is. Why do you clear the pending exception at line 1601? thanks, Coleen On 9/12/2013 3:21 PM, serguei.spit...