[ping] Re: RFR 8034168: ThreadMXBean/Locks.java failed, blocked on wrong object

2014-03-03 Thread Jaroslav Bachorik
On 25.2.2014 14:45, Jaroslav Bachorik wrote: On 20.2.2014 18:04, Martin Buchholz wrote: I think David is too pessimistic about Thread.yield being ineffective on Java SE implementations (OTOH David is a Java Embedded expert). In practice an implementation that never thread switched out of a yiel

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

2014-03-03 Thread Frederic Parain
Alan, Thank you for the review. I can use open64, even if I doubt the psinfo file would be so big that it requires a 64-bits offset (it contains a kernel data structure mapped to a file and its size is currently 336 bytes). JVM_Open was not restartable. JVM_Read was restartable, but none of the

Re: RFR(XS) 6625574: MemoryMXBean/Pending.java fails: "pending finalization = 0 but expected > 0"

2014-03-03 Thread Mattias Tobiasson
Staffan, could you please sponsor this fix? Thanks, Mattias - Original Message - From: staffan.lar...@oracle.com To: mattias.tobias...@oracle.com Cc: serviceability-dev@openjdk.java.net Sent: Friday, February 28, 2014 1:58:44 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / V

RFR: 8036132 Tab characters in test/com/sun/jdi files

2014-03-03 Thread Staffan Larsen
Just changing a lot of tabs into a lot more spaces. Easiest to view in the patch file. webrev: http://cr.openjdk.java.net/~sla/8036132/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8036132 Thanks, /Staffan

Re: RFR(XS) 8031065: LowMemoryTest2.sh fails: OutOfMemoryError: Metaspace

2014-03-03 Thread Mattias Tobiasson
Daniel, could you please sponsor this fix? Mattias - Original Message - From: daniel.fu...@oracle.com To: mattias.tobias...@oracle.com, shanliang.ji...@oracle.com Cc: serviceability-dev@openjdk.java.net Sent: Friday, February 28, 2014 12:05:47 PM GMT +01:00 Amsterdam / Berlin / Bern / Ro

Re: RFR: 8036132 Tab characters in test/com/sun/jdi files

2014-03-03 Thread Mikael Vidstedt
I randomly chose a file and ended up looking at GetLocalVariables4Test.sh where the indentation of all the lines in main() appear to be off - the tab should have been translated to 8 spaces in this case, not 4? Cheers, Mikael On 2014-03-03 05:30, Staffan Larsen wrote: Just changing a lot o

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

2014-03-03 Thread Alan Bateman
On 03/03/2014 10:30, Frederic Parain wrote: : I'd prefer to keep open() and read() as they are, for the sake of simplicity. In the unlikely case where one of these calls gets interrupted, it would simply generate a transient error in the value returned by OperatingSystem.getCommittedVirtualMemor

Re: JDK-7090324: gclog rotation via external tool

2014-03-03 Thread Yumin Qi
Yasumasa, Seems no comments for this email so far. I have some comments of the changes: 1) arguments.cpp: a) line 1896 & 1897, please merge these two lines into one, the length will not exceeds longest lines in this file. b) line 1898 - 1990, move line back 4 spaces, in hotspot we

Re: RFR: 8036132 Tab characters in test/com/sun/jdi files

2014-03-03 Thread Staffan Larsen
Thanks for noticing! The same mistake was in all the inlined Java code. new webrev: http://cr.openjdk.java.net/~sla/8036132/webrev.01/ /Staffan On 3 mar 2014, at 21:04, Mikael Vidstedt wrote: > > I randomly chose a file and ended up looking at GetLocalVariables4Test.sh > where the indentatio

Re: RFR: 8036132 Tab characters in test/com/sun/jdi files

2014-03-03 Thread Staffan Larsen
Missed one more place in CatchPatternTest.sh: http://cr.openjdk.java.net/~sla/8036132/webrev.02/ /Staffan On 4 mar 2014, at 08:09, Staffan Larsen wrote: > Thanks for noticing! The same mistake was in all the inlined Java code. > > new webrev: http://cr.openjdk.java.net/~sla/8036132/webrev.01/

Re: RFR: 8036132 Tab characters in test/com/sun/jdi files

2014-03-03 Thread Mikael Vidstedt
Looks good. Cheers, Mikael On 2014-03-03 23:24, Staffan Larsen wrote: Missed one more place in CatchPatternTest.sh: http://cr.openjdk.java.net/~sla/8036132/webrev.02/ /Staffan On 4 mar 2014, at 08:09, Staffan Larsen wrote: Thanks for noticing! The same mistake was in all the inlined Java