Re: RFR: 8041934 com/sun/jdi/RepStep.java fails on all platforms with assert(_cur_stack_depth == count_frames()) failed: cur_stack_depth out of sync

2014-05-08 Thread Mikael Auno
Note that RepStep was just added to ProblemList due to this issue and will have to be removed from there when the fix is integrated. Mikael On 2014-05-08 08:06, Staffan Larsen wrote: > All, > > This is a fix for an assert in JVMTI that verifies that JVMTI’s internal > notion of the number of f

Re: RFR: 8039173 Propagate errors from Diagnostic Commands as exceptions in the attach framework

2014-05-08 Thread Alan Bateman
On 29/04/2014 15:08, Staffan Larsen wrote: Thanks for the comments. I have updated the review with both. webrev: http://cr.openjdk.java.net/~sla/8039173/webrev.05/ I do not actually have any Reviewers for this change. Anyone willing to take it on is much appreciated. Sorry for the delay, I'v

Re: RFR: 8039173 Propagate errors from Diagnostic Commands as exceptions in the attach framework

2014-05-08 Thread Staffan Larsen
Thank you, Alan! On 8 maj 2014, at 17:40, Alan Bateman wrote: > On 29/04/2014 15:08, Staffan Larsen wrote: >> Thanks for the comments. I have updated the review with both. >> >> webrev: http://cr.openjdk.java.net/~sla/8039173/webrev.05/ >> >> I do not actually have any Reviewers for this chang

Re: RFR: 8039173 Propagate errors from Diagnostic Commands as exceptions in the attach framework

2014-05-08 Thread Dmitry Samersoff
Staffan, Looks good for me. Could you comment in bug report that this changeset also fixes incorrect usage of off parameter in *VirtualMachine_read functions. -Dmitry On 2014-04-29 18:08, Staffan Larsen wrote: > Thanks for the comments. I have updated the review with both. > > webrev: http

Re: RFR: 8041934 com/sun/jdi/RepStep.java fails on all platforms with assert(_cur_stack_depth == count_frames()) failed: cur_stack_depth out of sync

2014-05-08 Thread Daniel D. Daugherty
> webrev: http://cr.openjdk.java.net/~sla/8041934/webrev.00/ src/share/vm/runtime/sharedRuntime.hpp No comments. src/share/vm/runtime/sharedRuntime.cpp line 994: JRT_LEAF(int, SharedRuntime::jvmti_method_exit( I'm not sure that JRT_LEAF is right. I would think that JvmtiE

Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-05-08 Thread David Holmes
Hi Jeremy, On 9/05/2014 4:56 AM, Jeremy Manson wrote: I'm testing out my newly acquired OpenJDK authorship with something simple. If I did this wrong, I apologize. Basically, the debugger becomes very slow if there are a lot of methods in a class. This can happen (O(thousands)) if you are usi