Ok.
/Staffan
On 2 sep 2014, at 21:31, Dmitry Samersoff wrote:
> Please review,
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8035419/webrev.01/
>
> Added couple of missed exception checks to sawindbg.cpp
>
> -Dmitry
>
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersbur
Look good.
Thanks,
Serguei
On 9/2/14 12:31 PM, Dmitry Samersoff wrote:
Please review,
http://cr.openjdk.java.net/~dsamersoff/JDK-8035419/webrev.01/
Added couple of missed exception checks to sawindbg.cpp
-Dmitry
This is a review for a backport of JDK-8044135 to jdk8u. This fix had a few
dependencies that also needed backporting, so included in this review are the
following fixes from JDK9:
• 8044135 Add API to start JMX agent from attach framework (jdk)
• 8039173 Propagate errors from Diagnostic Command
…nd the link:
http://cr.openjdk.java.net/~sla/8044398-8039173-8044135-jdk8u/webrev.00/
/Staffan
On 3 sep 2014, at 14:25, Staffan Larsen wrote:
> This is a review for a backport of JDK-8044135 to jdk8u. This fix had a few
> dependencies that also needed backporting, so included in this rev
Please, review this trivial test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8057150
Webrev: http://cr.openjdk.java.net/~jbachorik/8057150/webrev.00
This change is to provide us with more info about why the test fails as
described in https://bugs.openjdk.java.net/browse/JDK-8057149
Looks good!
Thanks,
/Staffan
On 3 sep 2014, at 15:43, Jaroslav Bachorik wrote:
> Please, review this trivial test change
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8057150
> Webrev: http://cr.openjdk.java.net/~jbachorik/8057150/webrev.00
>
> This change is to provide us with more in
Hi Jaroslav,
Looks good.
I wonder however - are these messages internationalized?
If so could it be a locale/env issue (e.g. matching english
against some other language)?
best regards,
-- daniel
On 9/3/14 3:43 PM, Jaroslav Bachorik wrote:
Please, review this trivial test change
Issue : htt
Please, review this test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8057134
Webrev: http://cr.openjdk.java.net/~jbachorik/8057134/webrev.02
Currently the test expects one of the following exception types when
trying to connect to a port not being server by the management agent -
N
On 09/03/2014 03:57 PM, Daniel Fuchs wrote:
Hi Jaroslav,
Looks good.
I wonder however - are these messages internationalized?
If so could it be a locale/env issue (e.g. matching english
against some other language)?
I am not 100% certain. The strange thing is that you can see the error
messa
Looks good!
Thanks,
/Staffan
On 3 sep 2014, at 16:02, Jaroslav Bachorik wrote:
> Please, review this test change
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8057134
> Webrev: http://cr.openjdk.java.net/~jbachorik/8057134/webrev.02
>
> Currently the test expects one of the following e
Hi Jaroslav,
- import java.net.ConnectException;
java.net.ConnectException is not a RemoteException, but
java.rmi.ConnectException is.
I wonder whether the connect code may throw java.net.ConnectException,
or whether the test was wrong in the first place.
If the java.net.ConnectException may b
On 09/03/2014 04:30 PM, Daniel Fuchs wrote:
Hi Jaroslav,
- import java.net.ConnectException;
java.net.ConnectException is not a RemoteException, but
java.rmi.ConnectException is.
I wonder whether the connect code may throw java.net.ConnectException,
or whether the test was wrong in the first p
Looks good!
On 9/3/14 4:47 PM, Jaroslav Bachorik wrote:
On 09/03/2014 04:30 PM, Daniel Fuchs wrote:
Hi Jaroslav,
- import java.net.ConnectException;
java.net.ConnectException is not a RemoteException, but
java.rmi.ConnectException is.
I wonder whether the connect code may throw java.net.Conn
13 matches
Mail list logo
