Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

Looks like only the first Interface will be considered if no srcAddress is provided (succeeded will be false and we will throw to exit the while loop). Is this intended? Thanks! /peter > On 4 sep 2014, at 17:59, Yasumasa Suenaga wrote: > > Hi all, > > Thank you so much, Dmitry! > > I've cre

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

Hi Peter, I fixed it and created new webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.1/ Could you review it again? Thanks, Yasumasa (2014/09/05 17:20), Peter Allwin wrote: Looks like only the first Interface will be considered if no srcAddress is provided (succeeded will b

Re: RFR: 8057174: MemoryMXBean tests -- TEST FAILED: chunkSize: 6291456 is less than YOUNG_GEN_SIZE: 8388608

Hi Daniel, On 2014-09-04 16:58, Daniel Fuchs wrote: Looks good Stefan! Thanks a lot for reviewing. I realized that I need to do some extra hardening so I'll have to send out an updated version of the test. thanks, StefanK best regards, -- daniel On 9/4/14 4:34 PM, Stefan Karlsson wrot

Re: RFR: 8057174: MemoryMXBean tests -- TEST FAILED: chunkSize: 6291456 is less than YOUNG_GEN_SIZE: 8388608

Hi all, Here's an updated version of the test: http://cr.openjdk.java.net/~stefank/8057174/webrev.01.delta/ http://cr.openjdk.java.net/~stefank/8057174/webrev.01/ 1) The max == -1 check would unnecessarily fail the test (if it ever would happen). 2) Some flags/configurations could increase th

RFR(XS): 8057686: Clean up ProblemList.txt

Hi, Could I please have a review of this fix for ProblemList.txt. bug: https://bugs.openjdk.java.net/browse/JDK-8057686 webrev: http://cr.openjdk.java.net/~ykantser/8057686/webrev.00/ Thanks, Katja

Re: RFR(XS): 8057686: Clean up ProblemList.txt

Looks good! -JB- On 09/05/2014 02:38 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix for ProblemList.txt. bug: https://bugs.openjdk.java.net/browse/JDK-8057686 webrev: http://cr.openjdk.java.net/~ykantser/8057686/webrev.00/ Thanks, Katja

Re: RFR(XS): 8057686: Clean up ProblemList.txt

Jaroslav, Thank you for the review! Could you please be my sponsor and push the fix? The patch is attached to this mail. // Katja On 09/05/2014 03:01 PM, Jaroslav Bachorik wrote: Looks good! -JB- On 09/05/2014 02:38 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of t

Re: RFR: Backport of JDK-8044135: Add API to start JMX agent from attach framework

On 04/09/2014 19:44, Staffan Larsen wrote: Hi Jaroslav, Thanks for the comments. I think they are valid, but I would prefer to do them in a separate changeset if that is ok with you? I still need a JDK 8u Reviewer to look at this. /Staffan I think this looks okay and matches the changes in J

Re: RFR: JDK-8055845 - Add trace event for promoted objects

Hi, I have uploaded a new webrev here, cr.openjdk.java.net/~sfriberg/8055845/webrev.03 It contains several changes - Split event into two events (PromoteObjectInNewPLAB, PromoteObjectOutsidePLAB) - Moved events to "vm/gc/detailed/PromoteObject..." - Supporting ParNew+CMS and Par