Re: RFR(S): JDK-7076820 assert(addr != 0) failed: address sanity check in PerfMemory::detach with -XX:-UsePerfData

David, On 2015-01-13 08:10, David Holmes wrote: > > Short version: okay but I'm going to file a bug to have sun.misc.Perf > fixed properly. Thank you and please, file a new bug (you can assign it to me directly). -Dmitry > > Long version ... read below :) > > Thanks, > David > > On 12/01/2

RFR: 8068774 CounterMonitorDeadlockTest.java timed out

Hi Please review this test bug fix Bug: https://bugs.openjdk.java.net/browse/JDK-8068774 Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8068774/00/ The problem must be here: 98 monitorProxy.start(); 99 100 final int initGetCount = observedProxy.getGetCount(); The test calls initGetCount after

Re: jmx-dev RFR: 8068774 CounterMonitorDeadlockTest.java timed out

Looks good! Just don't forget to add "noreg-self" label to the issue. -JB- On 13.1.2015 10:28, shanliang wrote: Hi Please review this test bug fix Bug: https://bugs.openjdk.java.net/browse/JDK-8068774 Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8068774/00/ The problem must be here: 98 m

Re: jmx-dev RFR: 8068774 CounterMonitorDeadlockTest.java timed out

On 13/01/15 10:28, shanliang wrote: Hi Please review this test bug fix Bug: https://bugs.openjdk.java.net/browse/JDK-8068774 Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8068774/00/ Looks good Shanliang! best regards, -- daniel The problem must be here: 98 monitorProxy.start(); 99 100

RFR: JDK-8067945: SVC jdk/test/* should be cleaned from JRE layout dependency

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8067945 webrev: http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8067945/webrev.00/ References to tools.jar are removed from the tests as jdk9 drops tools.jar Thanks, Alex

Re: RFR: JDK-8067945: SVC jdk/test/* should be cleaned from JRE layout dependency

Hi Alexander, test/com/sun/tools/attach/BasicTests.java L84 can be completely removed; no need to put on classpath test/com/sun/tools/attach/PermissionTest.java L77 can be completely removed; no need to put on classpath test/com/sun/tools/attach/TempDirTest.java L126 can be completely removed

Re: RFR 8067447: Factor out the shared implementation of the VM flags manipulation code

Hi Staffan, On 13/01/2015 5:26 PM, Staffan Larsen wrote: On 8 jan 2015, at 14:24, Jaroslav Bachorik wrote: On 8.1.2015 12:12, David Holmes wrote: On 8/01/2015 7:22 PM, Jaroslav Bachorik wrote: On 8.1.2015 03:45, David Holmes wrote: On 8/01/2015 1:59 AM, Jaroslav Bachorik wrote: On 7.1.20

Re: RFR 8067447: Factor out the shared implementation of the VM flags manipulation code

> On 13 jan 2015, at 13:21, David Holmes wrote: > > Hi Staffan, > > On 13/01/2015 5:26 PM, Staffan Larsen wrote: >> >>> On 8 jan 2015, at 14:24, Jaroslav Bachorik >>> wrote: >>> >>> On 8.1.2015 12:12, David Holmes wrote: On 8/01/2015 7:22 PM, Jaroslav Bachorik wrote: > On 8.1.2015

RFR(S): 8068613: Wrong number of objects pending finalization start

Hi, Could I please have a review of this test bug fix. bug: https://bugs.openjdk.java.net/browse/JDK-8068613 webrev: http://cr.openjdk.java.net/~ykantser/8068613/webrev.00/ On line 90 and on line 246 (in the old version) the test does

Re: RFR(S): 8068613: Wrong number of objects pending finalization start

Y'all should import GcFinalization for use as a testing utility. http://code.google.com/p/guava-libraries/source/browse/guava-testlib/src/com/google/common/testing/GcFinalization.java On Tue, Jan 13, 2015 at 4:55 AM, Mattias Tobiasson < mattias.tobias...@oracle.com> wrote: > Hi, > Could I please

RFR 8067982: some jcmd /gc/heap_dump tests failed: hprof output contains warning or error

Hi, Please review the fix for JDK-8067982 (Some jcmd /gc/heap_dump tests failed: hprof output contains warning or error). The jcmd heap_dump tests failed due to incomplete symbol information in the dump output. The shared symbols are not incl

Re: A hotspot patch for stack profiling (frame pointer)

Filed RFE: https://bugs.openjdk.java.net/browse/JDK-8068945 Regards, Vladimir On 12/9/14 2:14 AM, Erik Helin wrote: I should also add that I don't have enough knowledge of the compiler internals to review this patch, sorry. Thanks, Erik On 2014-12-09 10:53, Erik Helin wrote: I applied the p

Re: RFR 8067982: some jcmd /gc/heap_dump tests failed: hprof output contains warning or error

Looks good to me. Could you update the copyright year? Thanks Yumin On 1/13/2015 4:50 PM, Jiangli Zhou wrote: Hi, Please review the fix for JDK-8067982 (Some jcmd /gc/heap_dump tests failed: hprof output contains warning or error). The jcmd

4-th round RFR (XS) 8068162: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found

Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8068162 Open webrevs: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8068162-JVMTI-old.4/ http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/jdk/8068162-Test-IsModifiableAgent/ Summary: The sun.misc.Unsafe:thr

Re: RFR 8067447: Factor out the shared implementation of the VM flags manipulation code

Hi Staffan, On 13/01/2015 10:27 PM, Staffan Larsen wrote: On 13 jan 2015, at 13:21, David Holmes mailto:david.hol...@oracle.com>> wrote: Hi Staffan, On 13/01/2015 5:26 PM, Staffan Larsen wrote: On 8 jan 2015, at 14:24, Jaroslav Bachorik mailto:jaroslav.bacho...@oracle.com>> wrote: On 8.1