RFR(XS): 8076154: com/sun/jdi/InstanceFilter.java failing due to missing MethodEntryRequest calls

Please review this small test fix for JDK- 8076154. Bug: https://bugs.openjdk.java.net/browse/JDK-8076154 Webrev: http://cr.openjdk.java.net/~farvidsson/8076154/webrev.00/ I am planning to backport this fix to 8u-dev as soon as it is reviewed and integrated in 9. Cheers /F

Re: RFR(XS): 8076154: com/sun/jdi/InstanceFilter.java failing due to missing MethodEntryRequest calls

Looks good! Thanks, /Staffan > On 27 mar 2015, at 14:34, Fredrik Arvidsson > wrote: > > Please review this small test fix for JDK- 8076154. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8076154 > > Webrev: http://cr.openjdk.java.net/~far

RFR[ 9u-dev] JDK-8072863 - Replace fatal() with vm_exit_during_initialization() when an incorrect class is found on the bootclasspath

Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8072863. I have built the JDK9 with fix successfully. As I do not have account for OpenJDK, David Buck will push the fix into jdk9/hs-rt/. Web review link: http://cr.openjdk.java.net/~dbuck/8072863/webrev.00/ Regar

Re: RFR 8054890: Serviceability: New diagnostic commands 'VM.set_flag' and 'JVMTI.data_dump'

The tests looks good! Thank you very much for fixing. // Katja On 03/23/2015 12:41 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 23 mar 2015, at 11:55, Jaroslav Bachorik wrote: On 23.3.2015 08:50, Staffan Larsen wrote: diagnosticCommand.cpp: - Should SetVMFlagDCmd really be i

Re: Please review draft JEP: JMX Specific Annotations for Registration of Managed Resources

On 26.3.2015 03:47, Eamonn McManus wrote: A couple more comments on the draft as it stands. I like the approach of @NotificationSupport on fields. However, the name is not great I think. Maybe nest an @Inject annotation inside NotificationSender, so you could write @NotificationSender.Inject

RFR 8023093: Add ManagementAgent.status diagnostic command

Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8023093 Webrev: http://cr.openjdk.java.net/~jbachorik/8023093/webrev.00 (hotspot, jdk) This change adds a new 'ManagementAgent.status' diagnostic command. This command will output the current status of the ma

Re: RFR[ 9u-dev] JDK-8072863 - Replace fatal() with vm_exit_during_initialization() when an incorrect class is found on the bootclasspath

This looks fine. -JB- On 27.3.2015 08:36, cheleswer sahu wrote: Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8072863. I have built the JDK9 with fix successfully. As I do not have account for OpenJDK, David Buck will push the fix into jdk9/hs-rt/. Web review

Re: RFR(XS): 8076154: com/sun/jdi/InstanceFilter.java failing due to missing MethodEntryRequest calls

Looks good! -JB- On 27.3.2015 14:34, Fredrik Arvidsson wrote: Please review this small test fix for JDK- 8076154. Bug: https://bugs.openjdk.java.net/browse/JDK-8076154 Webrev: http://cr.openjdk.java.net/~farvidsson/8076154/webrev.00/ I am planning to backport this fix to 8u-dev as soon as it

Re: RFR (XS) 8066679: jvmtiRedefineClasses.cpp assert cache ptrs must match

This fix looks correct. Is there any way to write a test for this? thanks, Coleen On 3/25/15, 9:16 PM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8066679 Open hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hots

Re: RFR (XS) 8066679: jvmtiRedefineClasses.cpp assert cache ptrs must match

Thanks, Coleen! I'll check about test. Thanks, Serguei On 3/27/15 11:46 AM, Coleen Phillimore wrote: This fix looks correct. Is there any way to write a test for this? thanks, Coleen On 3/25/15, 9:16 PM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.j

Re: inlining AllocateHeap()

Sorry for the delay. I filed it to JBS and uploaded webrev: JDK-8076212: AllocateHeap() and ReallocateHeap() should be inlined. http://cr.openjdk.java.net/~ysuenaga/JDK-8076212/webrev.00/ Could you review it? > Yasumasa you will need to file a CR and you will need a sponsor to push > your