RFR 8135188: RunFinalizationTest.java Exception java.lang.Error: Test failure: Object was not finalized

2015-10-08 Thread Jaroslav Bachorik
Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8135188 Webrev: http://cr.openjdk.java.net/~jbachorik/8135188/webrev.00 The problem is described in detail in the issue. This patch follows the recommendation by Dan Daugherty and runs the part where final

RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Jaroslav Bachorik
Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/jdk Issue description: "MXBean currently supports model-specific types

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Alan Bateman
On 08/10/2015 12:49, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/jdk I see this patch is against

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Daniel Fuchs
Hi Jaroslav, I'll look at the code in more details, but doesn't your webrev miss some modifications to modules.xml? oh - I see you have module-info.java - are you planning to push that in jake repo first then? best regards, -- daniel On 08/10/15 13:49, Jaroslav Bachorik wrote: Please, review

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Jaroslav Bachorik
On 8.10.2015 14:15, Alan Bateman wrote: On 08/10/2015 12:49, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top http://cr.openjdk.java.net/~jbachorik/7199353/w

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Alan Bateman
On 08/10/2015 13:26, Jaroslav Bachorik wrote: The patch is adding a new exported package to java.management - so it would have to be adjusted to the way jdk9 defines modules right now (eg. modules.xml). And then do this again for jigsaw/jake I would, personally, prefer to do the change only

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Daniel Fuchs
Hi Jaroslav, 1. I think it would be good to change the synopsis of the issue to match what the proposed change does. It seems to me that something like: Add a new javax.management.annotation.ConstructorProperties annotation would be a better description. 2. I agree with Alan th

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Alan Bateman
On 08/10/2015 14:15, Daniel Fuchs wrote: : 3. I was told recently that @since 1.9 should now be @since 9 (package-info + new annotation type) JEP 223 isn't in JDK 9 yet. I've no doubt there will be a s/1.9/9/g when it goes in, it will probably need to be done a few times to ensure changes

Re: RFR 8135188: RunFinalizationTest.java Exception java.lang.Error: Test failure: Object was not finalized

2015-10-08 Thread Daniel D. Daugherty
On 10/8/15 1:37 AM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8135188 Webrev: http://cr.openjdk.java.net/~jbachorik/8135188/webrev.00 test/serviceability/dcmd/gc/RunFinalizationTest.java L54: out.stderrShouldB

RE: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Iris Clark
Hi, Alan. > JEP 223 isn't in JDK 9 yet. I've no doubt there will be a s/1.9/9/g when it > goes in, it will probably need to be done a few times to ensure changes in > progress at the time of the switch are caught. Correct. For reference, here's the bug: 8136494: Update "@since 1.9" to "@s

Re: RFR 8135188: RunFinalizationTest.java Exception java.lang.Error: Test failure: Object was not finalized

2015-10-08 Thread Martin Buchholz
Hi Jaroslav, we all keep writing finalization code like this... welcome to the club! I think it would be better : - never use currentTimeMillis to measure elapsed time; use nanoTime instead - why use complex Phaser when simple CountDownLatch will do? I just concidentally wrote this code, which

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Mandy Chung
On 10/08/2015 04:49 AM, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/jdk I think #2 in the rul

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Mandy Chung
On 10/08/2015 05:41 AM, Alan Bateman wrote: I'm not sure that I agree with logging a warning when java.beans.ConstructorProperties is used. I would be tempted to leave that out. The idea is that we want users to stop using @j.b.CP for JMX purposes. So we might as well warn them about the sub

Re: RFR 8135188: RunFinalizationTest.java Exception java.lang.Error: Test failure: Object was not finalized

2015-10-08 Thread Jaroslav Bachorik
On 8.10.2015 18:56, Martin Buchholz wrote: Hi Jaroslav, we all keep writing finalization code like this... welcome to the club! I think it would be better : - never use currentTimeMillis to measure elapsed time; use nanoTime instead Ok. I suppose this would be because currentTimeMillis() i