On 8.12.2015 04:38, David Holmes wrote:
On 8/12/2015 6:54 AM, serguei.spit...@oracle.com wrote:
Hi Jaroslav,
Looks good.
Would it more clean with the "volatile" keyword ?
45 public static boolean active = true;
If set and read in different threads then it must be volatile. Else C2
can turn i
On 8.12.2015 04:52, Mandy Chung wrote:
On Dec 7, 2015, at 7:42 PM, David Holmes wrote:
On 8/12/2015 1:54 AM, Roger Riggs wrote:
Hi Jaroslav,
Is this just to accommodate the test library? I found no other
references in java.base.
If so, then perhaps it can be placed in another package that
On 12/8/15 02:16, Jaroslav Bachorik wrote:
On 8.12.2015 04:38, David Holmes wrote:
On 8/12/2015 6:54 AM, serguei.spit...@oracle.com wrote:
Hi Jaroslav,
Looks good.
Would it more clean with the "volatile" keyword ?
45 public static boolean active = true;
If set and read in different threads
Harold, Coleen and Serguei,
Thanks for your help in reviewing so far.
I have created an updated changeset which I intend to push if you are ok with
it, please see:
http://cr.openjdk.java.net/~mgronlun/8140485/unified/unified_review/webrev05/
Coleen,
I went back to the CheckIntrinsic piece, a
Hi David,
Please review the code changes in updated webrev
http://cr.openjdk.java.net/~kevinw/8138745/webrev.02/
Regards,
Cheleswer
On 12/8/2015 4:36 AM, David Holmes wrote:
Hi Cheleswer,
Thanks. Just a few minor updates ...
On 3/12/2015 4:58 PM, cheleswer sahu wrote:
Hi,
Thanks David and St
Hello,
Please review my conversion of -XX:+TraceExceptions to
-Xlog:exceptions=info. The existing (product) flag is aliased to the
logging flag at the info level.
If you have any questions on the alias table (in the arguments.cpp and
.hpp files), Max will chime in as he is the one who implem
Hi,
Are the aliases listed in the -XX usage help?
+TraceExceptions is so much easier to understand and use than the new flag.
Thanks, Roger
On 12/08/2015 10:42 AM, Rachel Protacio wrote:
Hello,
Please review my conversion of -XX:+TraceExceptions to
-Xlog:exceptions=info. The existing (produ
On 12/8/15 5:35 AM, Markus Gronlund wrote:
Harold, Coleen and Serguei,
Thanks for your help in reviewing so far.
I have created an updated changeset which I intend to push if you are ok with
it, please see:
http://cr.openjdk.java.net/~mgronlun/8140485/unified/unified_review/webrev05/
Cole
[Adding serviceability-dev@openjdk.java.net]
Hi Mikael,
Thanks for pointing this out. I'll look into it some more. Are there any
tests that should be failing as a result of this? I get the feeling no,
since I see other issues here that existed before my change. For
example, this code is not r
Hi all,
I use HSDB / CLHSDB when I have to analyze coredump image.
For example, if JVM is crashed in static JNI method (e.g. ZIP archive
operation),
I want to find oop (like "this" pointer) address from upper call frame.
We can find it from stack, however, it is hard.
So I want to show it in eac
Ping:
Please review it.
http://cr.openjdk.java.net/~ysuenaga/JDK-8144332/webrev.00/
Thanks,
Yasumasa
On 2015/12/01 23:35, Yasumasa Suenaga wrote:
> Hi all,
>
> When I ran HSDB through jhsdb, I could not terminate it through window close
> button.
> HSDB starts WorkerThread. It will be ter
Hi Rachel,
On 9/12/2015 1:42 AM, Rachel Protacio wrote:
Hello,
Please review my conversion of -XX:+TraceExceptions to
-Xlog:exceptions=info. The existing (product) flag is aliased to the
logging flag at the info level.
Q: how does use of ttyLocker map into UL? I see an awful lot of
multi-lin
On 8/12/2015 9:26 PM, cheleswer sahu wrote:
Hi David,
Please review the code changes in updated webrev
http://cr.openjdk.java.net/~kevinw/8138745/webrev.02/
Looks good! Only one more thing I forgot to mention - no new webrev
needed. When you use the testlibrary you also need to ensure it gets
13 matches
Mail list logo
