PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

PING: Could you review it? We need more reviewer. >> http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/ Thanks, Yasumasa On 2016/03/31 22:33, Yasumasa Suenaga wrote: > CC'ed to serviceability-dev. > > Could you review it? > >> http://cr.openjdk.java.net/~ysuenaga/JDK-815307

PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

PING: Could you review and sponsor it? >> http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.00/ Thanks, Yasumasa On 2016/03/31 22:35, Yasumasa Suenaga wrote: > CC'ed to serviceability-dev. > > Could you review it? > >> http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.00

RFR(8u) JDK-8153252: SA: Hotspot build on Windows fails if make/closed folder does not exist

Hello, Please review this simple fix. Bug JDK-8153252 : SA: Hotspot build on Windows fails if make/closed folder does not exist Problem: The problem is that the SA build on windows fails while building non-openjdk commercial sources that don'

RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

Summary: Constant pool merging is not thread safe for source_file_name. This change includes the change for the following bug because they are tested together. 8148772: VM crash in nsk/jvmti/RedefineClasses/StressRedefine: assert failed: Corrupted constant pool Summary: ConstantPool::resolve_

Re: RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

Coleen, src/share/vm/prims/jvmtiRedefineClasses.cpp - // Update the version number of the constant pool + // Update the version number of the constant pools (may keep scratch_cp) merge_cp->increment_and_save_version(old_cp->version()); + scratch_cp->increment_and_save_version(old_cp->version(

Re: RFR 8150607 - Clean up CompactHashtable

Hi Ioi, I like the more structural way of reading/writing the compact table with SimpleCompactHashtable. It looks quite clean overall. - How about using VALUE_ONLY_BUCKET_TYPE, which is more descriptive than TINY_BUCKET_TYPE? - The following assert in CompactSymbolTableWriter::add() limits the

Re: RFR 8150607 - Clean up CompactHashtable

Hi Jiangli, Thanks for the review: On 4/11/16 6:44 PM, Jiangli Zhou wrote: Hi Ioi, I like the more structural way of reading/writing the compact table with SimpleCompactHashtable. It looks quite clean overall. - How about using VALUE_ONLY_BUCKET_TYPE, which is more descriptive than TINY_B

Re: RFR (XS): 8153902 remove com/sun/jdi/InterfaceMethodsTest.java, com/sun/jdi/InvokeTest.java from ProblemList

Ping... Thanks, Serguei On 4/8/16 16:04, serguei.spit...@oracle.com wrote: Please, review this trivial, test-only change (enabling previously excluded tests). Bug: https://bugs.openjdk.java.net/browse/JDK-8153902 Summary: The tests need to be enabled again after the fix of: JDK-815367

Re: RFR (XS): 8153902 remove com/sun/jdi/InterfaceMethodsTest.java, com/sun/jdi/InvokeTest.java from ProblemList

+1 -Sundar On 4/12/2016 11:42 AM, serguei.spit...@oracle.com wrote: > Ping... > > Thanks, > Serguei > > > On 4/8/16 16:04, serguei.spit...@oracle.com wrote: >> Please, review this trivial, test-only change (enabling previously >> excluded tests). >> >> Bug: >> https://bugs.openjdk.java.net/brow

Re: RFR (XS): 8153902 remove com/sun/jdi/InterfaceMethodsTest.java, com/sun/jdi/InvokeTest.java from ProblemList

Thanks, Sundar! Serguei On 4/11/16 23:18, Sundararajan Athijegannathan wrote: +1 -Sundar On 4/12/2016 11:42 AM, serguei.spit...@oracle.com wrote: Ping... Thanks, Serguei On 4/8/16 16:04, serguei.spit...@oracle.com wrote: Please, review this trivial, test-only change (enabling previously