Re: RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

2016-04-18 Thread Severin Gehwolf
Hi Dmitry, On Fri, 2016-04-15 at 21:59 +0300, Dmitry Samersoff wrote: > Severin, > > Looks good for me. Thanks for the review! > But I'm a little afraid of the fact that now we are holding > eventHandler_lock while doing invoke*. OK. FWIW, we need to hold this lock for proper lock ordering. Ot

RFR [9] 8147553: Remove sun.misc.ManagedLocalsThread from java.management

2016-04-18 Thread Chris Hegarty
8056152 added a new constructor to java.lang.Thread to constructing Threads that do not inherit inheritable-thread-local initial values. Given there is now a supported API for creating such threads, other areas of the JDK should be updated to use it. This change updates the code in java.manage

Re: RFR [9] 8147553: Remove sun.misc.ManagedLocalsThread from java.management

2016-04-18 Thread Daniel Fuchs
Hi Chris, The changes look good to me. best regards, -- daniel On 18/04/16 12:37, Chris Hegarty wrote: 8056152 added a new constructor to java.lang.Thread to constructing Threads that do not inherit inheritable-thread-local initial values. Given there is now a supported API for creating such

PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-04-18 Thread Yasumasa Suenaga
PING: I've sent review request for JDK-8153074. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.00/ If this patch is merged, user can confirm output option via VM.log jcmd. Please review and sponsor it. Thanks, Yasumasa On 2016/04/11 18:29, Yasumasa Suenaga

PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

2016-04-18 Thread Yasumasa Suenaga
PING: I've sent review request for JDK-8153073. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/ If this patch is merged, user can set logfile size with k/m/g. Please review it. Thanks, Yasumasa On 2016/04/11 18:28, Yasumasa Suenaga wrote: > PING: Could

bug in JVMTI

2016-04-18 Thread k...@kodewerk.com
Hi all, For almost a year (j)VisualVM (jFluid) has been running into this JVMTI bug. # Problematic frame: # V [libjvm.dylib+0x44691c] Method::checked_resolve_jmethod_id(_jmethodID*)+0x22 …. Current thread (0x7ffdcc08b000): JavaThread "*** Profiler Agent Communication Thread" daemon [_th

Re: bug in JVMTI

2016-04-18 Thread Staffan Larsen
What bug is this on bugs.openjdk.java.net ? > On 18 apr. 2016, at 20:09, k...@kodewerk.com wrote: > > Hi all, > > For almost a year (j)VisualVM (jFluid) has been running into this JVMTI bug. > > # Problematic frame: > # V [libjvm.dylib+0x44691c] > Method::check

Unable to extract usable hprof heap dump from core file with Java 8

2016-04-18 Thread Basil Crow
Hi all, I posted a message a few months ago entitled "Unable to create hprof heap dump from core file with jmap on Oracle Solaris" [1] to describe my difficulties creating a usable hprof heap dump from a core file with jmap with Java 8. Despite the fact that JDK-8044416 has been resolved, the prob

Re: bug in JVMTI

2016-04-18 Thread Vladimir Ivanov
There's the following bug filed: https://bugs.openjdk.java.net/browse/JDK-8147451 Best regards, Vladimir Ivanov On 4/18/16 9:17 PM, Staffan Larsen wrote: What bug is this on bugs.openjdk.java.net ? On 18 apr. 2016, at 20:09, k...@kodewerk.com

Re: bug in JVMTI

2016-04-18 Thread k...@kodewerk.com
Hi all, This works in 7 and 9 (not tried a recent build of 9) but breaks in every version of 8 I’ve tried. Is there a way to get the fix in 8? Kind regards, Kirk Pepperdine > On Apr 18, 2016, at 2:38 PM, Vladimir Ivanov > wrote: > > There's the following bug filed: > https://bugs.openjdk.ja

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-18 Thread Alex Henrie
2016-04-14 2:35 GMT-06:00 serguei.spit...@oracle.com : > Your fix has been pushed. Thanks! Could you send me a link to the repository that it was pushed to? I'm not seeing it in jdk9/dev/jdk. -Alex

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-18 Thread serguei.spit...@oracle.com
The fix was pushed to the jdk9/hs-rt. It will take some time (a week or two) to be promoted to the jdk9/dev. Thanks, Serguei On 4/18/16 13:17, Alex Henrie wrote: 2016-04-14 2:35 GMT-06:00 serguei.spit...@oracle.com : Your fix has been pushed. Thanks! Could you send me a link to the repositor

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-18 Thread Daniel D. Daugherty
Serguei, Even though the JPRT "succeeded", the push itself failed: hg --config ui.merge=false push --repository /net/scaaa637.us.oracle.com/export/ archives/data/jprt/archive/2016/04/2016-04-13-173931.sspitsyn.8145278/sourcetree /jdk --noninteractive --time pushing to ssh://sspit...@hg.openjdk

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-18 Thread serguei.spit...@oracle.com
Dan, Thank you for the notice! Will check and re-submit the job. Thanks, Serguei On 4/18/16 13:40, Daniel D. Daugherty wrote: Serguei, Even though the JPRT "succeeded", the push itself failed: hg --config ui.merge=false push --repository /net/scaaa637.us.oracle.com/export/ archives/data/jp

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-18 Thread Daniel D. Daugherty
On 4/18/16 2:55 PM, serguei.spit...@oracle.com wrote: Dan, Thank you for the notice! No problem. I just happened to notice that my changeset notification tracker didn't report that one going by... and we were watching stuff closed on 2016.04.13 and 2016.04.14 due to the upcoming JDK9-hs-rt mer

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-18 Thread Daniel D. Daugherty
On 4/18/16 2:57 PM, Daniel D. Daugherty wrote: On 4/18/16 2:55 PM, serguei.spit...@oracle.com wrote: Dan, Thank you for the notice! No problem. I just happened to notice that my changeset notification tracker didn't report that one going by... and we were watching stuff closed on 2016.04.13 a

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-18 Thread serguei.spit...@oracle.com
On 4/18/16 13:57, Daniel D. Daugherty wrote: On 4/18/16 2:55 PM, serguei.spit...@oracle.com wrote: Dan, Thank you for the notice! No problem. I just happened to notice that my changeset notification tracker didn't report that one going by... and we were watching stuff closed on 2016.04.13 and

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

2016-04-18 Thread David Holmes
Hi Yasumasa, On 19/04/2016 12:06 AM, Yasumasa Suenaga wrote: > PING: > > I've sent review request for JDK-8153073. > Could you review it? > > http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/ > > If this patch is merged, user can set logfile size with k/m/g. Your webrev seems out