Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

2016-09-09 Thread serguei.spit...@oracle.com
On 9/8/16 22:46, David Holmes wrote: On 9/09/2016 8:48 AM, Yasumasa Suenaga wrote: Could you, please, send a full webrev for this last suggestion? I uploaded a webrev. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8164913/webrev.03/ This minimalist change looks okay to me.

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

2016-09-09 Thread Yasumasa Suenaga
2016/09/09 16:02 "serguei.spit...@oracle.com" : > > On 9/8/16 22:46, David Holmes wrote: >> >> On 9/09/2016 8:48 AM, Yasumasa Suenaga wrote: Could you, please, send a full webrev for this last suggestion? >>> >>> >>> I uploaded a webrev. Could you review it? >>> >>> http://cr.openjdk.ja

Re: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

2016-09-09 Thread Alexander Kulyakhtin
Hi Mandy, Thank you very much for the review. I have added @modules java.instrument, making no other changes. Please, find the updated webrev at http://cr.openjdk.java.net/~akulyakh/8139368_04/ Best regards, Alexander - Original Message - From: mandy.ch...@oracle.com To: alexander.ku

Re: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

2016-09-09 Thread Alan Bateman
On 09/09/2016 13:07, Alexander Kulyakhtin wrote: Hi Mandy, Thank you very much for the review. I have added @modules java.instrument, making no other changes. Please, find the updated webrev at http://cr.openjdk.java.net/~akulyakh/8139368_04/ The updated webrev looks good to me. -Alan

Re: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

2016-09-09 Thread Alexander Kulyakhtin
Alan, Thank you very much for the review. Best regards, Alexander - Original Message - From: alan.bate...@oracle.com To: alexander.kulyakh...@oracle.com Cc: serviceability-dev@openjdk.java.net Sent: Friday, September 9, 2016 3:09:16 PM GMT +03:00 Iraq Subject: Re: RFR:8139368:-javaagent

Re: RFR: JDK-8165493: SA: Add method in GrowableArray.java to be able to access the 'data' field

2016-09-09 Thread Erik Gahlin
Could you change to: return dataField.getValue(getAddress()); Otherwise it looks good. No need to upload new webrev. Not a (R)eviewer. Thanks Erik On 2016-09-08 23:40, Poonam Bajaj Parhar wrote: Hello, Please review this small change that adds an accessor method to GrowableArray class for i

Re: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

2016-09-09 Thread Mandy Chung
+1 Mandy > On Sep 9, 2016, at 5:07 AM, Alexander Kulyakhtin > wrote: > > Hi Mandy, > > Thank you very much for the review. I have added @modules java.instrument, > making no other changes. > Please, find the updated webrev at > http://cr.openjdk.java.net/~akulyakh/8139368_04/ > > Best reg

Re: RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

2016-09-09 Thread Severin Gehwolf
Hi, Could I please get a review of the this 4th version of this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8153711 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153711/webrev.03/ It fixes a memory leak problem in the debugger as shown by the new regression test. A bit of his

Re: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

2016-09-09 Thread serguei.spit...@oracle.com
Hi Alexander, This looks good. There is a confusion with the CR header. Should you get rid of the " and -Dcom.sun.management" part in it? Thanks, Serguei On 9/9/16 05:07, Alexander Kulyakhtin wrote: Hi Mandy, Thank you very much for the review. I have added @modules java.instrument, making