Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-28 Thread Dmitry Samersoff
Chris, Looks good for me. But please, wait for Serguei. -Dmitry On 2016-09-21 08:07, Chris Plummer wrote: > Hello, > > Please help review the following: > > https://bugs.openjdk.java.net/browse/JDK-8161225 > http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ > > The main fix is in JPLI

Re: RFR(XS): 8166806: Add intrinsic support for writer used in event based tracing

2016-09-28 Thread Vladimir Kozlov
Hi Markus, Where _getBufferWriter is defined? I don't see closed changes. c1_LIRGenerator.cpp: should you use oopConst(NULL) in compare? library_call.cpp: TypeInstPtr::MIRROR is useless since the result phi type is TypePtr::BOTTOM. Using TypePtr::BOTTOM for load could be less bug prone. Tha