RE: RFR(XS): 8166806: Add intrinsic support for writer used in event based tracing

Thanks Vladimir for taking a look, I have done some minor updates to the webrev: Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev02/ Bug: http://bugs.openjdk.java.net/browse/JDK-8166806 The associated closed changes have been sent internally. Thanks Markus -Original Message

Re: RFR(XS): 8155570: serviceability/tmtools/jstat/GcTest02.java fails with parallel GC

Hi Leonid, (not a reviewer) Maybe a comment explaining why the metaspace should be eaten first could be useful? Otherwise it might be not clear that the order of the methods is important and the methods can be unintentionally swapped again? Best regards, Alexander - Original Message

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Hi Dmitry, On 10/4/16 05:59, Dmitry Samersoff wrote: Serguei, Exact code executed by original version of this tests depends to what tests was run before: 1. We have to explicitly @build JpsBase to put it into jar file. 2. Couple of testlibrary classes are build because of JpsBase.java depen

Re: RFR(XS): 8155570: serviceability/tmtools/jstat/GcTest02.java fails with parallel GC

Let me put following comment in eatMetaspaceAndHeap method: @Override public void eatMetaspaceAndHeap(float targetMemoryUsagePercent) { +// Metaspace should be filled before Java Heap to prevent unexpected OOME +// in the Java Heap while filling Metaspace +eate

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Serguei, > This comments above became out-dated now. fixed. (in-place, press shift-reload) > Nice. Consider it reviewed. Thanks, Serguei Thank you. I'll run rbt job and proceed with push if everything is OK. -Dmitry On 2016-10-05 16:02, serguei.spit...@oracle.com wrote: > Hi Dmitry, > >

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Dmitry, Thank you for the update. Good luck with rbt run and push. Thanks, Serguei On 10/5/16 08:48, Dmitry Samersoff wrote: Serguei, This comments above became out-dated now. fixed. (in-place, press shift-reload) Nice. Consider it reviewed. Thanks, Serguei Thank you. I'll run rbt j

RFR(XS): 8167001: [TESTBUG] java/lang/instrument/DaemonThread/TestDaemonThread.java fails when run by jprt

Hello, [Sorry if some of you are seeing this a second time. I used the wrong alias the first time around] Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167001 http://cr.openjdk.java.net/~cjplummer/8167001

Re: RFR(XS): 8166806: Add intrinsic support for writer used in event based tracing

Looks good. Thanks, Vladimir On 10/5/16 2:33 AM, Markus Gronlund wrote: Thanks Vladimir for taking a look, I have done some minor updates to the webrev: Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev02/ Bug: http://bugs.openjdk.java.net/browse/JDK-8166806 The associated closed c

Re: RFR(XS): 8167001: [TESTBUG] java/lang/instrument/DaemonThread/TestDaemonThread.java fails when run by jprt

Hi Chris, This seems fine. As you say there may be a number of ways to address this problem, but this is clear and simple and does fix it. Thanks, David On 6/10/2016 3:30 AM, Chris Plummer wrote: Hello, [Sorry if some of you are seeing this a second time. I used the wrong alias the first ti

Re: RFR(XS): 8167001: [TESTBUG] java/lang/instrument/DaemonThread/TestDaemonThread.java fails when run by jprt

Hi Chris, Looks good. Thanks, Serguei On 10/5/16 10:30, Chris Plummer wrote: Hello, [Sorry if some of you are seeing this a second time. I used the wrong alias the first time around] Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167001 http://cr.openjdk.java.net