Hi Roger,
I was not sure about adding exitVM.* as that would give permissions for
all exit codes.
Maybe Fred can comment since he is the test case author.
-Harsha
On Friday 18 November 2016 08:58 PM, Roger Riggs wrote:
Hi Harsha,
The addition of the permission for
Looks good to me.
Fred
On 11/18/2016 04:47 AM, Harsha Wardhana B wrote:
Hello All,
Please review below fix for issue
https://bugs.openjdk.java.net/browse/JDK-8169575
having webrev at,
http://cr.openjdk.java.net/~hb/8169575/webrev.00/
Regards
Harsha
Thumbs up.
Fred
On 11/18/2016 10:43 AM, Harsha Wardhana B wrote:
Hello,
Please review below webrev incorporating Roger's comment.
http://cr.openjdk.java.net/~hb/8169575/webrev.01/
-Harsha
On Friday 18 November 2016 09:08 PM, Frederic Parain wrote:
"exitVM.*" should be fine to avoid
Looks fine.
Roger
On 11/18/2016 1:57 AM, Amy Lu wrote:
Please review the patch to bring back test:
java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Mac OSX
As mentioned in JDK-8072130, failure is not reproducible.
I also tested it with different version of macOS, test all
Hello,
Please review below webrev incorporating Roger's comment.
http://cr.openjdk.java.net/~hb/8169575/webrev.01/
-Harsha
On Friday 18 November 2016 09:08 PM, Frederic Parain wrote:
"exitVM.*" should be fine to avoid future maintenance burden.
Thank you for pointing this out Roger.
Fred
+1
On 11/18/2016 10:43 AM, Harsha Wardhana B wrote:
Hello,
Please review below webrev incorporating Roger's comment.
http://cr.openjdk.java.net/~hb/8169575/webrev.01/
-Harsha
On Friday 18 November 2016 09:08 PM, Frederic Parain wrote:
"exitVM.*" should be fine to avoid future maintenance
Hi Harsha,
The addition of the permission for
"getProperty.jdk.jar.disabledAlgorithms" is fine.
But the addition of a permission for exitVM.95 to satisfy the need of
the test harness to exit cleanly
should instead be fixed by changing the "exitVM.97" to "exitVM.*" to
avoid future
"exitVM.*" should be fine to avoid future maintenance burden.
Thank you for pointing this out Roger.
Fred
On 11/18/2016 10:32 AM, Harsha Wardhana B wrote:
Hi Roger,
I was not sure about adding exitVM.* as that would give permissions for
all exit codes.
Maybe Fred can comment since he is the
Hi Jini,
This looks good to me.
Thanks,
Serguei
On 11/17/16 19:52, Jini Susan George wrote:
Could I get one more reviewer to take a look at this, please?
Thanks,
Jini.
-Original Message-
From: Dmitry Samersoff
Sent: Wednesday, November 16, 2016 4:06 PM
To: Jini Susan George;
Hello All,
Please review below fix for issue
https://bugs.openjdk.java.net/browse/JDK-8169575
having webrev at,
http://cr.openjdk.java.net/~hb/8169575/webrev.00/
Regards
Harsha
10 matches
Mail list logo
