JDK 9 RFR for JDK-8174241: ProblemList update for TestWsImport, JdbMethodExitTest and jimage tests

2017-02-09 Thread Amy Lu
Please review the ProblemList.txt cleanup on updating bugid for several tests. javax/xml/ws/clientjar/TestWsImport.java8170370 generic-all This test is in ProblemList, related bug JDK-8170370 has been resolved. Test is going to be revisited in JDK-8173317 tools/jimage/JImageExtractTest.ja

Re: JDK 9 RFR for JDK-8174241: ProblemList update for TestWsImport, JdbMethodExitTest and jimage tests

2017-02-09 Thread Lance Andersen
+1 > On Feb 9, 2017, at 4:32 AM, Amy Lu wrote: > > Please review the ProblemList.txt cleanup on updating bugid for several tests. > > javax/xml/ws/clientjar/TestWsImport.java8170370 generic-all > This test is in ProblemList, related bug JDK-8170370 has been resolved. Test > is going to be r

Re: 8173941 Re: SA does not work if executable is DSO

2017-02-09 Thread Yasumasa Suenaga
Hi Andrew, I checked with GDB, readelf and libsaproc debug message. I found that we should calculate .dynamic address from entry point in ELF. I uploaded webrev. This patch works fine on JDK 9 and JDK 10. http://cr.openjdk.java.net/~ysuenaga/JDK-8173941/webrev.00/ Thanks, Yasumasa On 201

Re: 8173941 Re: SA does not work if executable is DSO

2017-02-09 Thread Andrew Haley
On 09/02/17 14:40, Yasumasa Suenaga wrote: > Hi Andrew, > > I checked with GDB, readelf and libsaproc debug message. > I found that we should calculate .dynamic address from entry point in ELF. > > I uploaded webrev. This patch works fine on JDK 9 and JDK 10. > >http://cr.openjdk.java.net/~y

Re: 8173941 Re: SA does not work if executable is DSO

2017-02-09 Thread Yasumasa Suenaga
I guess this isn't the physical page size, but some notional 4k page, which may or may not correspond to the real page size? I think we should use sysconf(3) with _SC_PAGESIZE or p_align in ELF PHDR. +// Align page size +ph->core->dynamic_addr = auxv->a_un.a_val & ~(uin

Re: 8173941 Re: SA does not work if executable is DSO

2017-02-09 Thread Andrew Haley
On 09/02/17 14:57, Yasumasa Suenaga wrote: > So I think we can use sysconf(3) to get page size. In OpenJDK code we should use os::vm_page_size() for the physical page size. Andrew.

Re: RFR(S): 8173013: JVMTI tagged object access needs G1 pre-barrier

2017-02-09 Thread sangheon
Hi David, If you don't have any other questions/comments, can I proceed to push? Kim, thank you very much for the all explanations. Thanks, Sangheon On 02/07/2017 11:00 PM, Kim Barrett wrote: On Feb 6, 2017, at 10:44 PM, David Holmes wrote: Does the SATB occur at a global safepoint? SATB

Re: 8173941 Re: SA does not work if executable is DSO

2017-02-09 Thread Yasumasa Suenaga
On 2017/02/10 1:04, Andrew Haley wrote: On 09/02/17 14:57, Yasumasa Suenaga wrote: So I think we can use sysconf(3) to get page size. In OpenJDK code we should use os::vm_page_size() for the physical page size. SA is not part of HotSpot (not in libjvm). Thus SA cannot access HotSpot internal

Re: RFR(S): 8173013: JVMTI tagged object access needs G1 pre-barrier

2017-02-09 Thread David Holmes
On 10/02/2017 4:54 AM, sangheon wrote: Hi David, If you don't have any other questions/comments, can I proceed to push? Sorry - yes, of course. Kim, thank you very much for the all explanations. Yes much appreciated! Thanks, David Thanks, Sangheon On 02/07/2017 11:00 PM, Kim Barrett w

Re: 8173941 Re: SA does not work if executable is DSO

2017-02-09 Thread Yasumasa Suenaga
Hi Andrew, We can calculate start address of executable (java command) through entry point. I updated webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8173941/webrev.01/ This patch can ignore page size. Thanks, Yasumasa 2017-02-10 7:53 GMT+09:00 Yasumasa Suenaga : > On 2017/02/10 1:04, A