Re: RFR: JDK-6515161 If remote removeNotificationListener gets SecurityException, client no longer gets notifications

2017-05-04 Thread Ujwal Vangapally
corrected webrev link : http://cr.openjdk.java.net/~uvangapally/webrev/2017/6515161/webrev.00/ On 5/4/2017 12:14 PM, Ujwal Vangapally wrote: Kindly review the changes made for below bug Problem description and solution are explained in comments section https://bugs.openjdk.java.net/browse/J

Re: Low-Overhead Heap Profiling

2017-05-04 Thread Robbin Ehn
Hi, To me the compiler changes looks what is expected. It would be good if someone from compiler could take a look at that. Added compiler to mail thread. Also adding Serguei, It would be good with his view also. My initial take on it, read through most of the code and took it for a ride.

Re: RFR 8179457: Remove demo/jvmti tests

2017-05-04 Thread Alan Bateman
On 28/04/2017 22:41, Alexandre (Shura) Iline wrote: Hi, Could you please take a quick look on a source code change to remove demo/jvmti tests: http://cr.openjdk.java.net/~shurailine/8179457/webrev.00/ The tests seem to only be testing the jvmti demos and not providing any useful test coverag

RFR(10)(M): JDK-8164563: Test nsk/jvmti/CompiledMethodUnload/compmethunload001 keeps reporting: PRODUCT BUG: class was not unloaded in 5

2017-05-04 Thread Chris Plummer
Hello, Please review the following changes: http://cr.openjdk.java.net/~cjplummer/8164563/webrev.00/webrev.hotspot/ https://bugs.openjdk.java.net/browse/JDK-8164563 There was an issue with CompileMethodUnload events not getting delivered. Short story is the root cause was the JvmtiDeferredEve

Re: RFR(10)(M): JDK-8164563: Test nsk/jvmti/CompiledMethodUnload/compmethunload001 keeps reporting: PRODUCT BUG: class was not unloaded in 5

2017-05-04 Thread David Holmes
Looks good Chris. I think we finally ended up with the cleanest and simplest solution. Thanks, David On 5/05/2017 8:38 AM, Chris Plummer wrote: Hello, Please review the following changes: http://cr.openjdk.java.net/~cjplummer/8164563/webrev.00/webrev.hotspot/ https://bugs.openjdk.java.net/br

Re: Low-Overhead Heap Profiling

2017-05-04 Thread serguei.spit...@oracle.com
Robbin, Thank you for forwarding! I will review it. Thanks, Serguei On 5/4/17 02:13, Robbin Ehn wrote: Hi, To me the compiler changes looks what is expected. It would be good if someone from compiler could take a look at that. Added compiler to mail thread. Also adding Serguei, It would be

Re: RFR(10)(M): JDK-8164563: Test nsk/jvmti/CompiledMethodUnload/compmethunload001 keeps reporting: PRODUCT BUG: class was not unloaded in 5

2017-05-04 Thread serguei.spit...@oracle.com
Hi Chris, The fix looks good. I like the simplification. Great bug hunt, Chris! Thanks, Serguei On 5/4/17 15:38, Chris Plummer wrote: Hello, Please review the following changes: http://cr.openjdk.java.net/~cjplummer/8164563/webrev.00/webrev.hotspot/ https://bugs.openjdk.java.net/browse/JDK-