Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Hi, If I'm not mistaken then this will make it impossible for earlier release to interoperate with newer releases as the LocalRMIClientSocketFactory class will not be present the client tries to deserialize the stub. best regards, -- daniel On 19/06/2017 11:52, Ujwal Vangapally wrote: Hi,

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

On 6/19/17 13:23, Mandy Chung wrote: On Jun 19, 2017, at 1:17 PM, serguei.spit...@oracle.com wrote: Hi Mandy, I've built the docs with your patch and the link is still not resolved. It points to the docs/api/specs/jpda/jpda.html It should point to docs/specs/jpda/jpda.html. I verified in

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

Hi Mandy, I've built the docs with your patch and the link is still not resolved. It points to the docs/api/specs/jpda/jpda.html But it is resolved if the patch is corrected with: + * Is it 9 or 10? Thanks, Serguei On 6/19/17 12:47, Mandy Chung wrote: Serguei, Can you review this

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

+ * >>> Is it 9 or 10? >>> >> I want to fix this simple docs bug in JDK 9. > > Ok, thanks. > > -Serguei > >> >> Mandy >> >>> Thanks, >>> Serguei >>> >>> >>> On 6/19/17 12:47, Mandy Chung wrote: Serguei, Can you review this patch fixing the link to JPDA? Mandy

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

Thumbs up. Thanks, Serguei On 6/19/17 13:34, Mandy Chung wrote: + * On Jun 19, 2017, at 1:31 PM, serguei.spit...@oracle.com wrote: On 6/19/17 13:23, Mandy Chung wrote: On Jun 19, 2017, at 1:17 PM, serguei.spit...@oracle.com wrote: Hi Mandy, I've built the docs with your patch and the

Review Request JDK-8181834: Broken link in jdk.jdi module documentation

Serguei, Can you review this patch fixing the link to JPDA? Mandy diff --git a/src/jdk.jdi/share/classes/module-info.java b/src/jdk.jdi/share/classes/module-info.java --- a/src/jdk.jdi/share/classes/module-info.java +++ b/src/jdk.jdi/share/classes/module-info.java @@ -39,12 +39,13 @@ *

Re: RFR(xs): 8181419: Race in jdwp invoker handling may lead to crashes or invalid results

Thank you Severin! On Mon, Jun 19, 2017 at 11:10 AM, Severin Gehwolf wrote: > Hi Thomas, > > On Tue, 2017-06-13 at 15:55 +0200, Thomas Stüfe wrote: > > Ping... Anyone? > > > > On Thu, Jun 1, 2017 at 2:18 PM, Thomas Stüfe > > wrote: > > > Hi all, >

RE: RFR(xs): 8181419: Race in jdwp invoker handling may lead to crashes or invalid results

Hi Thomas, this looks good to me. You still need to update the current year in the copyright header. Best regards Christoph From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 15. Juni 2017 08:31 To:

Re: RFR(xs): 8181419: Race in jdwp invoker handling may lead to crashes or invalid results

Thank you Christoph! On Mon, Jun 19, 2017 at 11:31 AM, Langer, Christoph < christoph.lan...@sap.com> wrote: > Hi Thomas, > > > > this looks good to me. You still need to update the current year in the > copyright header. > > > > Best regards > > Christoph > > > > *From:* serviceability-dev

Re: RFR(xs): 8181419: Race in jdwp invoker handling may lead to crashes or invalid results

Hi Thomas, On Tue, 2017-06-13 at 15:55 +0200, Thomas Stüfe wrote: > Ping... Anyone? > > On Thu, Jun 1, 2017 at 2:18 PM, Thomas Stüfe > wrote: > > Hi all, > > > > please take a look at this proposed fix for a theoretical race in > > the jdwp library. > > > > Issue: 

RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Hi, Kindly review the fix for bug below https://bugs.openjdk.java.net/browse/JDK-8173180 webrev: http://cr.openjdk.java.net/~uvangapally/webrev/2017/8173180/webrev.00/ Thanks, Ujwal