Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-12 Thread Harsha Wardhana B
Hi Mandy, On Wednesday 11 October 2017 11:48 PM, mandy chung wrote: On 10/8/17 10:34 PM, Harsha Wardhana B wrote: Hi Daniel, Below is the webrev addressing the review comments. http://cr.openjdk.java.net/~hb/5016517/webrev.04/ This approach seems reasonable.   I only review management.

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-12 Thread mandy chung
On 10/12/17 1:16 AM, Harsha Wardhana B wrote: I'm thinking any better alternative to the new property name?? com.sun.management.jmxremote.password.hashes com.sun.management.jmxremote.password.asHashes com.sun.management.jmxremote.passowrd.toHashes I suggest to rename com.sun.management

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-12 Thread Harsha Wardhana B
On Thursday 12 October 2017 08:40 PM, mandy chung wrote: On 10/12/17 1:16 AM, Harsha Wardhana B wrote: I'm thinking any better alternative to the new property name?? com.sun.management.jmxremote.password.hashes com.sun.management.jmxremote.password.asHashes com.sun.management.jmxremot

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-12 Thread mandy chung
On 10/12/17 8:18 AM, Harsha Wardhana B wrote: On Thursday 12 October 2017 08:40 PM, mandy chung wrote: On 10/12/17 1:16 AM, Harsha Wardhana B wrote: I'm thinking any better alternative to the new property name?? com.sun.management.jmxremote.password.hashes com.sun.management.jmxremote

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-12 Thread Harsha Wardhana B
Sure. I will send out a modified webrev soon. -Harsha On Thursday 12 October 2017 08:52 PM, mandy chung wrote: On 10/12/17 8:18 AM, Harsha Wardhana B wrote: On Thursday 12 October 2017 08:40 PM, mandy chung wrote: On 10/12/17 1:16 AM, Harsha Wardhana B wrote: I'm thinking any better

RFR (XS): 8175510 Null pointer dereference in getModuleObject of JPLISAgent.c:790

2017-10-12 Thread serguei.spit...@oracle.com
Please, review a fix for the Parfait bug:   https://bugs.openjdk.java.net/browse/JDK-8175510 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8175510-jplis-parfait.1/ Summary:     This is the main fragment

Re: RFR (XS): 8175510 Null pointer dereference in getModuleObject of JPLISAgent.c:790

2017-10-12 Thread David Holmes
Hi Serguei, Seems quite reasonable. Reviewed. Thanks, David On 13/10/2017 8:21 AM, serguei.spit...@oracle.com wrote: Please, review a fix for the Parfait bug: https://bugs.openjdk.java.net/browse/JDK-8175510 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8175510-jplis-parf

Re: RFR (XS): 8175510 Null pointer dereference in getModuleObject of JPLISAgent.c:790

2017-10-12 Thread serguei.spit...@oracle.com
Thanks for the quick review, David! Serguei On 10/12/17 18:01, David Holmes wrote: Hi Serguei, Seems quite reasonable. Reviewed. Thanks, David On 13/10/2017 8:21 AM, serguei.spit...@oracle.com wrote: Please, review a fix for the Parfait bug: https://bugs.openjdk.java.net/browse/JDK-8175510

RFR (S): 8187289 NotifyFramePop request is not cleared if JVMTI_EVENT_FRAME_POP is disabled

2017-10-12 Thread serguei.spit...@oracle.com
Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8187289 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.1/ Summary:   The issue is that the FRAME_POP event request is not cl