Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

Hi Yasumasa, I see the problem. As it occurred making these variables volatile is non-trivial. But thank you a lot for trying! I'd suggest to fall back to your previous approach as synchronization was not there in the first place, and it is not a part of the original issue you are trying to fi

RE: RFR(S): 8189425: Minor updates in support of closed changes

Hi Erik, Looks good. Thanks Markus -Original Message- From: Erik Gahlin Sent: den 18 oktober 2017 22:05 To: David Holmes; serviceability-dev@openjdk.java.net Subject: Re: RFR(S): 8189425: Minor updates in support of closed changes Hi David, > Hi Erik, > > On 18/10/2017 12:23 PM, Erik

Re: RFR: 8189373: jmap -heap exited with error code

Am 18.10.2017 um 20:29 schrieb Roman Kennke: My recent CMSHeap extraction has broken the JVM servicability agent. It looks like I actually need a little bit more boilerplate to make it happy: http://cr.openjdk.java.net/~rkennke/8189373/webrev.00/

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

Hi Serguei, Yasumasa, I suggest we leave the volatile off for now and file a RFE to add volatile_static_field support to VMStructs and update later. I don't think trying to introduce locking would be a good idea as it would likely lead to deadlocks when a crash occurs. This could also be inv

Re: RFR: 8189373: jmap -heap exited with error code

Your changes look good to me, Roman. Nit: Please do change the copyright year to 2017 in CollectedHeapName.java. Thank you, Jini (not a Reviewer). On 10/18/2017 11:59 PM, Roman Kennke wrote: My recent CMSHeap extraction has broken the JVM servicability agent. It looks like I actually need a li

Re: RFR: 8189373: jmap -heap exited with error code

I also took a look and it seemed okay - Jini is the expert so that's good enough for me. :) Reviewed. David On 19/10/2017 8:57 PM, Jini George wrote: Your changes look good to me, Roman. Nit: Please do change the copyright year to 2017 in CollectedHeapName.java. Thank you, Jini (not a Revie

Re: RFR: 8189373: jmap -heap exited with error code

Hi David, hi Jini, thank you both for review! Now I need a sponsor. Final patch (incl. summary and reviewed-by): http://cr.openjdk.java.net/~rkennke/8189373/webrev.01/ Thank you! Roman I also took a look and it seemed okay - Jini is

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

Hi, I suggest we leave the volatile off for now and file a RFE to add volatile_static_field support to VMStructs and update later. Okay. David or Serguei, could you file it? I'd suggest to fall back to your previous approach as synchronization was not there in the first place, and it is n

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

On 19/10/2017 9:44 PM, Yasumasa Suenaga wrote: Hi, I suggest we leave the volatile off for now and file a RFE to add volatile_static_field support to VMStructs and update later. Okay. David or Serguei, could you file it? I'd suggest to fall back to your previous approach as synchronization

Re: RFR: 8189373: jmap -heap exited with error code

On 19/10/2017 9:28 PM, Roman Kennke wrote: Hi David, hi Jini, thank you both for review! Now I need a sponsor. Final patch (incl. summary and reviewed-by): http://cr.openjdk.java.net/~rkennke/8189373/webrev.01/ I will sponsor this.

Re: RFR: 8189373: jmap -heap exited with error code

Am 19.10.2017 um 14:27 schrieb David Holmes: On 19/10/2017 9:28 PM, Roman Kennke wrote: Hi David, hi Jini, thank you both for review! Now I need a sponsor. Final patch (incl. summary and reviewed-by): http://cr.openjdk.java.net/~rkennke/8189373/webrev.01/

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

Sorry, I forgot the fix to use OrderAccess::load_acquire() in PerfMemory::is_initialized(). I fixed it in new webrev. Could you review again? http://cr.openjdk.java.net/~ysuenaga/JDK-8151815/webrev.09/ Yasumasa On 2017/10/19 21:24, David Holmes wrote: On 19/10/2017 9:44 PM, Yasumasa Suena

Re: RFR(S): 8189425: Minor updates in support of closed changes

Thanks for the review, David and Markus! Erik Hi Erik, Looks good. Thanks Markus -Original Message- From: Erik Gahlin Sent: den 18 oktober 2017 22:05 To: David Holmes; serviceability-dev@openjdk.java.net Subject: Re: RFR(S): 8189425: Minor updates in support of closed changes Hi Dav

[PATCH] Unnecessary Amount Of Internal Class Conversion

Per Alan's request here ( http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-October/049532.html ), I am redirecting my initial email to this mailing list ... I have observed a problem where an unnecessary amount of internal class conversion is occurring. I have a patch which I would like

Re: RFR: 8183542: Factor out serial GC specific code from GenCollectedHeap into its own subclass

Am 18.10.2017 um 22:41 schrieb Kim Barrett: On Oct 18, 2017, at 4:04 PM, Roman Kennke wrote: Am 18.10.2017 um 20:41 schrieb Kim Barrett: On Oct 18, 2017, at 8:08 AM, Roman Kennke wrote: Differential webrev: http://cr.openjdk.java.net/~rkennke/8183542/webrev.01.diff/

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

Hi Yasumasa, On 10/19/17 06:43, Yasumasa Suenaga wrote: Sorry, I forgot the fix to use OrderAccess::load_acquire() in PerfMemory::is_initialized(). I fixed it in new webrev. Could you review again?   http://cr.open

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

http://cr.openjdk.java.net/~ysuenaga/JDK-8151815/webrev.09/ It looks good to me. I've filed: https://bugs.openjdk.java.net/browse/JDK-8189685 need PerfMemory class update and a volatile_static_field support in VMStructs Thanks! Yasumasa On 2017/10/20 2:49, serguei.spit...@oracle.co

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

Looks good. (Sorry for the delay.) Thanks, David On 19/10/2017 11:43 PM, Yasumasa Suenaga wrote: Sorry, I forgot the fix to use OrderAccess::load_acquire() in PerfMemory::is_initialized(). I fixed it in new webrev. Could you review again?   http://cr.openjdk.java.net/~ysuenaga/JDK-8151815/we

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

Thank you, David! Yasumasa, could you, please, send me a patch? Thanks, Serguei On 10/19/17 22:05, David Holmes wrote: Looks good. (Sorry for the delay.) Thanks, David On 19/10/2017 11:43 PM, Yasumasa Suenaga wrote: Sorry, I forgot the fix to use OrderAccess::load_acquire() in PerfMemory::i