Hi Yasumasa,
Some comments.
http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.00/test/jdk/com/sun/tools/attach/StartManagementAgent.java.udiff.html
-if (!ex.getMessage().contains("Invalid com.sun.management.jmxremote.port number")) {
+
Hi Jini,
You have appended 'Field' for most of the SA variables. Example:
private static CIntegerField pcOffsetField;
pcOffsetField = type.getCIntegerField("_pc_offset");
However that is not the case in
private static long MinChunkSizeInBytes;
MinChunkSizeInBytes =
(type.getCIntegerField("_mi
Here is the updated webrev:
http://cr.openjdk.java.net/~jgeorge/8190307/webrev.01/
I have made changes to validate the test results of each command
separately, done away with the asserts and have added some more comments.
Thank you,
Jini.
On 10/31/2017 12:32 PM, Jini George wrote:
Thank you
>
http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/
make/test/JtregNativeHotspot.gmk
No comments.
src/hotspot/share/prims/jvmtiEventController.cpp
No comments.
src/hotspot/share/prims/jvmtiExport.cpp
No comments.
src/hotspot/share/prims/jvmtiExp
Hi Serguei,
Thank you for your comment!
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.01/
http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.00/test/jdk/com/sun/tools/attach/StartManagementAgent.java.udiff.html
- if (!ex.getMessage().contains("Invalid
Dan,
Thank you a lot for review!
Serguei
On 11/3/17 04:56, Daniel D. Daugherty wrote:
>
http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/
make/test/JtregNativeHotspo
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8059334
http://cr.openjdk.java.net/~cjplummer/8059334/webrev.00/webrev.open/
The CR is closed, so I'll try to explain the issue here. The very short
explanation is that the JVMTI test was enabling SINGLE STEP and doin
I'm not an expert in this area of code, but I'm wondering about
Vladimir's comment about ciEnv::jvmti_state_changed() in the bug
report. With your fix, maybe we don't need to check
ciEnv::jvmti_state_changed() (which doesn't seem to be enough by itself)
and throw away the compiled result. We
