The stacking at the safe point would be a huge win. Right now thread dump
consistency can really confuse people as the tooling will show two threads
owning the same lock at seemingly the same time. Reality, it’s just that people
didn’t realize you get a safe point for each thread therefor there
On Thu, May 10, 2018 at 9:13 AM, Kirk Pepperdine
wrote:
> The stacking at the safe point would be a huge win. Right now thread dump
> consistency can really confuse people as the tooling will show two threads
> owning the same lock at seemingly the same time. Reality, it’s just that
> people di
Hi David,
Thank you very much for the review and for the clarifications offline! I
have addressed your comments and have a new webrev at:
http://cr.openjdk.java.net/~jgeorge/8195613/webrev.01/index.html
Thanks,
Jini.
On 5/4/2018 12:23 PM, David Holmes wrote:
Hi Jini,
On 4/05/2018 2:17 AM,
Hello,
Please review the following simple fix for 8185803:
https://bugs.openjdk.java.net/browse/JDK-8185803
http://cr.openjdk.java.net/~cjplummer/8185803/webrev.00/
Although this bug has been around for nearly a year, it used to only
fail on Windows. After the push for JDK-8198426 last month,
Hello,
I'm withdrawing this RFR. I noticed with repeated runs it was sometimes
failing on Solaris. It looks like for the most part the test ran ok, but
then at the end of the log you see:
--Finish execution with sending "quit" command to JDB
--Sending cmd: quit
--Quit cmd was sent
--waitForFi
I was going to say that you also need to remove:
29 # @requires os.family != "windows"
30 # @key intermittent
:)
But something seems fishy about this bug to me anyway - comments added
to bug report.
Cheers,
David
On 11/05/2018 12:59 PM, Chris Plummer wrote:
Hello,
I'm withdrawing th
Hi Jini,
On 11/05/2018 5:34 AM, Jini George wrote:
Hi David,
Thank you very much for the review and for the clarifications offline! I
have addressed your comments and have a new webrev at:
http://cr.openjdk.java.net/~jgeorge/8195613/webrev.01/index.html
Looks fine.
A couple of minor comme
Forgot to add - no need to see an updated webrev.
Thanks,
David
On 11/05/2018 4:22 PM, David Holmes wrote:
Hi Jini,
On 11/05/2018 5:34 AM, Jini George wrote:
Hi David,
Thank you very much for the review and for the clarifications offline!
I have addressed your comments and have a new webrev