RFR: xs: JDK-8209342 - Problemlist SA tests on Solaris due to Error attaching to process: Can't create thread_db agent!

2018-08-14 Thread Sharath Ballal
Hello, Pls review this small fix to problem list SA testcases failing on Solaris. Bug ID: https://bugs.openjdk.java.net/browse/JDK-8209342 Webrev: http://cr.openjdk.java.net/~sballal/8209342/webrev.00/ Thanks, Sharath

Re: RFR: xs: JDK-8209342 - Problemlist SA tests on Solaris due to Error attaching to process: Can't create thread_db agent!

2018-08-14 Thread Daniel D. Daugherty
On 8/14/18 3:18 AM, Sharath Ballal wrote: Hello, Pls review this small fix to problem list SA testcases failing on Solaris. Bug ID: https://bugs.openjdk.java.net/browse/JDK-8209342 Webrev: http://cr.openjdk.java.net/~sballal/8209342/webrev.00/

Re: JDK-8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

2018-08-14 Thread Gary Adams
I did 1000 testruns with these changes. There were 3 failures due to "executor timeout" but those are not related to these changes (infrastructure). Webrev: http://cr.openjdk.java.net/~gadams/8034084/webrev.00/index.html Issue: https://bugs.openjdk.java.net/browse/JDK-8034084 On 8/12/18, 7:

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-14 Thread Per Liden
Hi, On 2018-08-11 14:06, Yasumasa Suenaga wrote: Hi Per, SA needs memory regions to generate class histogram. So it is difficult to use visitor model for it. I want to back to this issue when class unloading is implemented. If you want to pursue the path of walking the live set, then you ca

Re: RFR (S) 8201224: Make string buffer size dynamic

2018-08-14 Thread Alex Menkov
Hi Jc, Calculation of the required buffer size ("old fashion way") looks error-prone. I don't think we need to care about ancient SUSv2, I suppose C99 is supported by all (or almost all) compilers. But if you want to keep the code SUSv2-compatible, you can do something like char dummy = 0;

Re: JDK-8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

2018-08-14 Thread Alex Menkov
Hi Gary, I think check for RawMonitorWait error should be moved into the loop or exit loop condition can be updated to 243 if (endsCount == endsExpected || err != JVMTI_ERROR_NONE) { 244 break; 245 } --alex On 08/14/2018 10:03, Gary Adams wrote: I did 1000 testruns with these c

RFR [XS] 8207832 - ClhsdbCDSCore.java failed with "Couldn't find core file location"

2018-08-14 Thread Ioi Lam
Please review this simple fix.     https://bugs.openjdk.java.net/browse/JDK-8207832 http://cr.openjdk.java.net/~iklam/jdk12/8207832_ClhsdbCDSCore_file_location.v01/ On Linux, the core file location can be controlled via /proc/sys/kernel/core_pattern. It could have various patterns such as   

Re: RFR (S) 8201224: Make string buffer size dynamic

2018-08-14 Thread JC Beyler
Hi Alex, Thanks for looking at it. That simplifies the webrev to this then: http://cr.openjdk.java.net/~jcbeyler/8201224/webrev.02/ I inlined a few comments on your answers. Thanks for the review and hopefully the new one is better :-) Thanks, Jc On Tue, Aug 14, 2018 at 3:16 PM Alex Menkov w