Here's a quick fix to avoid the NPE using a getThreadGroup() which could
be null
if the thread has terminated.
Issue: https://bugs.openjdk.java.net/browse/JDK-8210252
diff --git a/test/jdk/com/sun/jdi/DebuggerThreadTest.java
b/test/jdk/com/sun/jdi/DebuggerThreadTest.java
--- a/test/jdk/com/
Looks good.
/Erik
On 2018-09-03 00:27, Alan Bateman wrote:
JDK-8210087 [1] is an issue with the launcher generated for jconsole.
The launcher needs to be compiled with --add-modules ALL-DEFAULT so
that plugins compiled (and run) in an unnamed module can make use of
exported APIs in modules
Hi Gary,
Why has the thread exited if the debuggee is still running?
Chris
On 9/4/18 5:22 AM, Gary Adams wrote:
Here's a quick fix to avoid the NPE using a getThreadGroup() which
could be null
if the thread has terminated.
Issue: https://bugs.openjdk.java.net/browse/JDK-8210252
diff --git
Hi Gary,
I'm Okay with this fix.
Thanks,
Serguei
On 9/4/18 05:22, Gary Adams wrote:
Here's a quick fix to avoid the NPE using a getThreadGroup() which
could be null
if the thread has terminated.
Issue: https://bugs.openjdk.java.net/browse/JDK-8210252
diff --git a/test/jdk/com/sun/jdi/Debu
Hi Chris,
fixed.
Updated webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/step3/webrev.04/
On 08/31/2018 15:53, Chris Plummer wrote:
Hi Alex,
Overall it looks good.
159 // jdb prompt when debuggee is not started nor suspended after
breakpoint
How about "and is not suspended". And
Looks good.
Chris
On 9/4/18 11:01 AM, Alex Menkov wrote:
Hi Chris,
fixed.
Updated webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/step3/webrev.04/
On 08/31/2018 15:53, Chris Plummer wrote:
Hi Alex,
Overall it looks good.
159 // jdb prompt when debuggee is not started nor suspen
I'm not sure which thread exited causes the NPE.
This patch will let the test continue and at least
let the list of threads be processed.
The test walks up the parents to the initial thread
and then "enumerates()" the set of the threads to check.
There is an inherent race condition in enumerate(
Can you reproduce the problem? If so, maybe to find out which thread is
a problem you could check for null, print the thread info, and then fail
the test.
Chris
On 9/4/18 11:14 AM, Gary Adams wrote:
I'm not sure which thread exited causes the NPE.
This patch will let the test continue and at
I haven't been able to reproduce the problem locally.
Trying larger test runs on mach5 now.
Here's the output from a successful test run.
If any of the threads exited, they would have a null group name.
Howdy!
Thread [0] group = 'system' name = 'Reference Handler' daemon = true
Thread [1] group
Hi Gary,
The failed case only had:
Thread [0] group = 'system' name = 'Reference Handler' daemon = true
Thread [1] group = 'system' name = 'Finalizer' daemon = true
Thread [2] group = 'system' name = 'Signal Dispatcher' daemon = true
Thread [3] group = 'system' name = 'process reaper' daemon = t
Hi Alex,
Thank you for the explanations and update!
Thanks,
Serguei
On 8/31/18 10:26, Alex Menkov wrote:
Hi Serguei,
On 08/30/2018 23:12, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks good in general but not sure I understand all the changes.
Could you, please, tell a little bit more
Hi Alex,
It looks good.
Just one minor question.
http://cr.openjdk.java.net/~amenkov/sh2java/step3/webrev.04/test/jdk/com/sun/jdi/NullLocalVariable.java.udiff.html
-dojdbCmds()
-{
- #set -x
- cmd stop at badscope:4 ; $sleepcmd
- runToBkpt
Hi Serguei,
sleepcmd is empty, so it's NOP.
--alex
On 09/04/2018 12:28, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks good.
Just one minor question.
http://cr.openjdk.java.net/~amenkov/sh2java/step3/webrev.04/test/jdk/com/sun/jdi/NullLocalVariable.java.udiff.html
-dojdbCmds()
-{
- #se
Okay, thanks!
Serguei
On 9/4/18 14:30, Alex Menkov wrote:
Hi Serguei,
sleepcmd is empty, so it's NOP.
--alex
On 09/04/2018 12:28, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks good.
Just one minor question.
http://cr.openjdk.java.net/~amenkov/sh2java/step3/webrev.04/test/jdk/com/sun
Hi Jc,
It looks good to me.
Thank you for this cleanup!
Thanks,
Serguei
On 9/4/18 16:12, JC Beyler wrote:
Hi all,
Continuing the removal
http://cr.openjdk.java.net/~iignatyev//8210112/webrev.00/index.html
> 2375 lines changed: 322 ins; 1662 del; 391 mod
Hi all,
could you please review the patch which removes jdk.testlibrary.ProcessTools
and its friends and replaces all theirs usages w/ corresponding classes from
jdk.test.lib.pro
16 matches
Mail list logo
