+1 from me.
Thanks,
David
On 15/09/2018 3:48 AM, Igor Ignatyev wrote:
Hi JC,
looks good to me.
(cc'ing hotspot-dev alias as it affects other teams' tests)
-- Igor
On Sep 14, 2018, at 9:50 AM, JC Beyler wrote:
Hi all,
Could I get a review for the following webrev:
Webrev: http://cr.openj
Looks good to me.
Thanks,
Jini (Not a (R)eviewer)
On 9/14/2018 7:03 PM, Severin Gehwolf wrote:
Hi,
Could I please get a review of this one-liner fix. It changes
optimization of libsaproc from -O0 to -O3 (as per Magnus' suggestion).
I've run servicability tests and haven't seen any new failures
I took a look at it all and it seems okay, though the use of the cached
jvmtiEnv pointer did not really need to be changed. As per the spec:
"JVM TI environments work across threads"
The caching and its use is somewhat hard to understand without seeing
where all the call paths are for the func
Hi Severin,
Looks good to me.
Thanks,
Sharath (not a Reviewer)
-Original Message-
From: Severin Gehwolf [mailto:sgehw...@redhat.com]
Sent: Friday, September 14, 2018 7:04 PM
To: build-dev; serviceability-dev
Subject: RFR: 8210647: libsaproc is being compiled without optimization.
Hi,
This looks fine to me Iris.
Thanks,
David
On 15/09/2018 8:01 AM, Iris Clark wrote:
Hi.
Please review the following changes to add a copyright line to the end
of the generated jvmti.html file:
8210775: JVM TI Spec missing copyright
bug: https://bugs.openjdk.java.net/browse/JDK-8210
