Re: RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

2018-11-03 Thread dean . long
I don't think suspending compiler threads is safe, especially if compiles are blocking/synchronous. dl On 11/2/18 4:29 PM, Daniil Titov wrote: Please review the change that fixes several tests failing with com.sun.jdi.ObjectCollectedException when running with Graal. There main problem here

Re: RFR (XS) 8213246: Fix typo in vmTestbase failuire to failure

2018-11-03 Thread JC Beyler
Thanks all, pushed :) Jc On Fri, Nov 2, 2018 at 4:25 PM Igor Ignatyev wrote: > LGTM > > -- Igor - a Reviewer > > On Nov 2, 2018, at 4:22 PM, Mikael Vidstedt > wrote: > > > Looks good. > > Cheers, > Mikael - not a Reviewer > > On Nov 2, 2018, at 4:05 PM, JC Beyler wrote: > > Hi all, > > Could I