Re: RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

2018-11-04 Thread Daniil Titov
Hi Chris, There were multiple issues here but with JDK-8193126 being fixed I can no longer observe metaspace related issues and suspending the target VM seems as a sufficient to prevent newly created objects being collected before we have a chance to call disableCollection() on them. I noticed

Re: RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

2018-11-04 Thread JC Beyler
Hi Daniil, Quick question about looking at the launch options, is there any reason you do not simply use: sun.hotspot.code.Compiler.isGraalEnabled(); Is it because you do not want to specifically call out Graal? Thanks, Jc On Sun, Nov 4, 2018 at 12:41 PM Daniil Titov wrote: > Hi Chris, > > Th

Re: RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

2018-11-04 Thread serguei.spit...@oracle.com
Hi Daniil, I agree with Chris below. Will tell more on reply to your reply. Thanks, Serguei On 11/2/18 20:59, Chris Plummer wrote: Hi Daniil, I thought the issue was that C2 was doing metadata allocations, and when it ran out of metaspace it did a GC (one that was not triggered by a failed

Re: RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

2018-11-04 Thread serguei.spit...@oracle.com
On 11/4/18 23:40, serguei.spit...@oracle.com wrote: Hi Daniil, I agree with Chris below. Will tell more on reply to your reply. Thanks, Serguei On 11/2/18 20:59, Chris Plummer wrote: Hi Daniil, I thought the issue was that C2 was doing metadata allocations, and when it ran out of metaspace

Re: RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

2018-11-04 Thread serguei.spit...@oracle.com
Hi Daniil, Just wanted to comment this as I understand it. On 11/4/18 12:40, Daniil Titov wrote: Hi Chris, There were multiple issues here but with JDK-8193126 being fixed I can no longer observe metaspace related issues and suspending the target VM seems as a sufficient to prevent newly cre