Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread serguei.spit...@oracle.com
Hi David, On 11/14/18 15:05, David Holmes wrote: Hi Serguei, On 15/11/2018 5:20 am, serguei.spit...@oracle.com wrote: Hi Thomas, Thank you for taking care about this issue! We recently also saw a couple of problems related to the compiler thread not being hidden. I have several comments

Re: Proposal: Always-on Statistical History

2018-11-14 Thread Kirk Pepperdine
Hi, I agree, this could be very useful… — Kirk > On Nov 14, 2018, at 10:29 AM, Simon Roberts > wrote: > > I would say this could be pretty useful. It's almost like a > platform-independent, process specific vmstat, with JVM extras. Given the > existence of jps, this seems to fit in that

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread David Holmes
Hi Serguei, On 15/11/2018 5:20 am, serguei.spit...@oracle.com wrote: Hi Thomas, Thank you for taking care about this issue! We recently also saw a couple of problems related to the compiler thread not being hidden. I have several comments to the fix. It would be really nice if there is any

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread Daniel D. Daugherty
On 11/14/18 6:01 PM, David Holmes wrote: On 15/11/2018 6:13 am, Daniel D. Daugherty wrote: I do not have a better idea at the moment. The ResourceExhausted event is one of many JVM/TI events. So we put in a special case for this event because an agent out in the world tries to do something

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread David Holmes
Hi Dan, Serguei, I'm going to combine my response to you both into one as it's the same discussion ... On 15/11/2018 9:28 am, Daniel D. Daugherty wrote: On 11/14/18 6:01 PM, David Holmes wrote: On 15/11/2018 6:13 am, Daniel D. Daugherty wrote: I do not have a better idea at the moment.

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread serguei.spit...@oracle.com
Hi Dan, I thought the same event is going to be posted again on a different thread. It was wrong assumption, so you are right, it is not a good approach to fix this issue. Thanks, Serguei On 11/14/18 11:32, Daniel D. Daugherty wrote: I have a philosophical problem with a fix like this.

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread David Holmes
On 15/11/2018 6:13 am, Daniel D. Daugherty wrote: I do not have a better idea at the moment. The ResourceExhausted event is one of many JVM/TI events. So we put in a special case for this event because an agent out in the world tries to do something that is not expressly forbidden by the spec,

Re: What actions are allowed in an JVMTI ResourceExhausted event handler?

2018-11-14 Thread JC Beyler
It seems what we do with other events that might have this type of "risk" is to defer the event to the ServiceThread, which is a Java thread, no? But perhaps for a resource exhausted just ignoring it for the compiler thread and letting another "Java thread" be aware of it and posting is a better

Re: What actions are allowed in an JVMTI ResourceExhausted event handler?

2018-11-14 Thread Thomas Stüfe
Hi JC, On Wed, Nov 14, 2018 at 3:56 PM JC Beyler wrote: > > It seems what we do with other events that might have this type of "risk" is > to defer the event to the ServiceThread, which is a Java thread, no? But > perhaps for a resource exhausted just ignoring it for the compiler thread and >

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread Daniel D. Daugherty
Adding serviceability-dev@... Since the proposed solution to the bug is to not post an event, I think the Serviceability Team (which owns JVM/TI) needs to be involved directly in the review. Dan On 11/14/18 9:28 AM, Thomas Stüfe wrote: Dear all, may I please have reviews on this small

Proposal: Always-on Statistical History

2018-11-14 Thread Thomas Stüfe
Hi all, We have that feature in our port which we would like to contribute, and I would like to gauge opinions. First off, I am not sure which list is correct. This is more of a serviceability issue, but implementation wise it fit hs-runtime better. I'll start with serviceability, but feel free

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread Daniel D. Daugherty
I do not have a better idea at the moment. The ResourceExhausted event is one of many JVM/TI events. So we put in a special case for this event because an agent out in the world tries to do something that is not expressly forbidden by the spec, but it is a bad thing to do with HotSpot. Okay.

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread serguei.spit...@oracle.com
Hi Thomas, Thank you for taking care about this issue! We recently also saw a couple of problems related to the compiler thread not being hidden. I have several comments to the fix. It would be really nice if there is any chance to have

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread serguei.spit...@oracle.com
On 11/14/18 11:20, serguei.spit...@oracle.com wrote: Hi Thomas, Thank you for taking care about this issue! We recently also saw a couple of problems related to the compiler thread not being hidden. I have several

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread Daniel D. Daugherty
I have a philosophical problem with a fix like this. The fix is making the assumption that the handler for this event will want to run Java code and if the event is posted from a Java thread that cannot run Java code, then we skip posting the event. If I happen to have a more conservative agent

Re: RFR(xs): 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread

2018-11-14 Thread Thomas Stüfe
Hi Dan, On Wed, Nov 14, 2018 at 8:32 PM Daniel D. Daugherty wrote: > > I have a philosophical problem with a fix like this. > > The fix is making the assumption that the handler for this event will want > to run Java code and if the event is posted from a Java thread that cannot > run Java code,

Re: Proposal: Always-on Statistical History

2018-11-14 Thread Simon Roberts
I would say this could be pretty useful. It's almost like a platform-independent, process specific vmstat, with JVM extras. Given the existence of jps, this seems to fit in that ecosystem well. I find myself having to work with windows just rarely enough that I'd have to look up how to get this

Re: Proposal: Always-on Statistical History

2018-11-14 Thread Bernd Eckenfels
Looks good Thomas, what would be the typical memory usage with the Default Settings? Does the downsampling support min/max style rollups? -- http://bernd.eckenfels.net Von: Thomas Stüfe Gesendet: Mittwoch, 14. November 2018 16:29 An: serviceability-dev@openjdk.java.net

Re: Proposal: Always-on Statistical History

2018-11-14 Thread Thomas Stüfe
Hi Bernd, On Wed, Nov 14, 2018 at 10:07 PM Bernd Eckenfels wrote: > > Looks good Thomas, thanks! > what would be the typical memory usage with the Default Settings? ~ 80 Kb. Its very small. > Does the downsampling support min/max style rollups? Not sure what you mean. Do you mean does it

Re: Proposal: Always-on Statistical History

2018-11-14 Thread Thomas Stüfe
Hi Simon, thank you. Yes, I combined vmstat/pidstat like features etc with internal JVM statistics. Note that part of that table is platform specific, so it looks slightly different on BSD/Windows/Solaris etc. The JVM values are always the same. Best Regards, Thomas On Wed, Nov 14, 2018 at 7:29