A number failures of threadstart002 have been reported on
windows-x64-debug builds.
This configuration has a jtreg timeout factor assigned so the test can
run 10x slower
and not experience a timeout.
Unfortunately, these older vmTestbase tests were not fully integrated
with the jtreg
timeou
Thank you so much for the great catch, JC! Yes, indeed, the test passed
inspite of 'printmado' being an unrecognized command. I have filed
https://bugs.openjdk.java.net/browse/JDK-8216352 to handle issues like
these.
I have the corrected webrev at:
http://cr.openjdk.java.net/~jgeorge/8215568/
Hi JC,
I believe that’s covered by https://bugs.openjdk.java.net/browse/JDK-8206013.
Regards,
Marty
From: JC Beyler
Sent: Tuesday, January 8, 2019 9:14 AM
To: Gary Adams
Cc: OpenJDK Serviceability
Subject: Re: RFR: JDK-8213001:
vmTestbase/nsk/jvmti/ThreadStart/threadstart002/Te
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8181313
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8181313/webrev.00/
It has passed all tests on submit repo, and serviceability/sa tests on
Linux x64.
Thanks,
Yasumas
Hi Paul and All,
Thanks a lot for your review and comments,
I have updated the webrev to
Webrev: http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8215623
Would you like to help review it. Thanks.
BRs
Lin
From: 臧琳
Sent: Monday, Janua
Hi Daniil,
Sorry this slipped through the Xmas break cracks :)
On 22/12/2018 12:04 pm, Daniil Titov wrote:
Hi David and Serguei,
Please review a new version of the fix that for Linux platform uses the proc
filesystem to retrieve the main class name for the running Java process.
Webrev: http:
Dear JC,
Thanks for your comments, I inlined my comments here:
http://cr.openjdk.java.net/~xiaofeya/8215622/webrev.01/src/hotspot/share/services/attachListener.cpp.udiff.html
- Should we do like the rest of the file and declare variables when needed
instead of doing them all at the star
Dear JC,
Thanks to point it out, I processed the “-file=” case in JMap.java but
forgot to do it in attachListener.cpp. I will do it in next webrev.
Cheers,
Lin
From: JC Beyler
Sent: Wednesday, January 9, 2019 10:51 AM
To: 臧琳
Cc: Hohensee, Paul ; serviceability-dev@openjdk.java.net
Subje
Hi all,
Could I get a review for a small-ish webrev that only changes white-spaces
(or removes unnecessary new lines):
Bug: https://bugs.openjdk.java.net/browse/JDK-8212824
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212824/webrev.00/
Thanks,
Jc
Thank you very much for the review, JC. My comments inline:
On 1/8/2019 12:22 AM, JC Beyler wrote:
http://cr.openjdk.java.net/~jgeorge/8215544/webrev.03/test/hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java.udiff.html
+ // by appending 'sudo' to it. Check now if sudo
passe
Hi all,
Fixing up the tests in vmTestbase to not be testing explicitly against
NSK_TRUE/NSK_FALSE. Here is the webrev to do that:
Bug: https://bugs.openjdk.java.net/browse/JDK-8212959
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212959/webrev.00/
Thanks,
Jc
Hi Jc,
On 9/01/2019 4:12 pm, JC Beyler wrote:
Hi all,
Fixing up the tests in vmTestbase to not be testing explicitly against
NSK_TRUE/NSK_FALSE. Here is the webrev to do that:
Bug: https://bugs.openjdk.java.net/browse/JDK-8212959
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212959/webrev.00
On 9/01/2019 4:43 pm, JC Beyler wrote:
Hi David,
I was not planning on doing it but we could. This change came from a
request to remove the booleans from tests for a prior webrev change.
I've seen previous conversations about wanting to test explicitly
against JNI_TRUE but thought this was a
13 matches
Mail list logo
