RFR: JDK-8158066: SourceDebugExtensionTest fails to rename file

SourceDebugExtensionTest was placed on the ProblemList because of filesystem rename issues on Windows 2012 test systems. The test does not appear to fail on the current mach5 test systems. There was some question concerning symbolic links that might have been problematic at that time. Additional t

Re: RFR: 8181313: SA: Remove libthread_db dependency on Linux

Hi Jini, Thank you for your comment. I uploaded a new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8181313/webrev.01/ It passed tests on submit repo. Could you review again? Yasumasa On 2019/01/10 15:10, Jini George wrote: Thank you for implementing this change, Yasumasa. It looks go

Re: RFR: JDK-8215568: Refactor SA clhsdb tests to use ClhsdbLauncher

Gentle reminder -- Could I please let a Reviewer to take a look at this? Thanks, Jini. On 1/8/2019 10:36 PM, Jini George wrote: Thank you so much for the great catch, JC! Yes, indeed, the test passed inspite of 'printmado' being an unrecognized command. I have filed https://bugs.openjdk.java.n

Re: RFR: 8181313: SA: Remove libthread_db dependency on Linux

Thanks, Yasumasa, but I meant removing the declaration and definition of ps_get_thread_area() also. I don't think it is needed anymore. Thanks, Jini. On 1/10/2019 6:50 PM, Yasumasa Suenaga wrote: Hi Jini, Thank you for your comment. I uploaded a new webrev:   http://cr.openjdk.java.net/~ysu

Re: RFR: JDK-8158066: SourceDebugExtensionTest fails to rename file

Hi Gary, On 10/01/2019 11:02 pm, gary.ad...@oracle.com wrote: SourceDebugExtensionTest was placed on the ProblemList because of filesystem rename issues on Windows 2012 test systems. The test does not appear to fail on the current mach5 test systems. There was some question concerning symbolic l

答复: [RFR]8215622: Add dump to file support for jmap histo

Hi Jc, Thanks a lot. it is not a necessary change, I forget to omit it:) BRs, Lin 发件人: JC Beyler 发送时间: 2019年1月11日 0:58:22 收件人: 臧琳 抄送: Hohensee, Paul; serviceability-dev@openjdk.java.net 主题: Re: [RFR]8215622: Add dump to file support for jmap histo Hi Lin, S

Re: RFR: 8181313: SA: Remove libthread_db dependency on Linux

Hi Jini, I removed ps_get_thread_area() in new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8181313/webrev.02/ Diff from webrev.01 is here: http://hg.openjdk.java.net/jdk/submit/rev/691a931ae2ba Thanks, Yasumasa 2019年1月11日(金) 1:05 Jini George : > > Thanks, Yasumasa, but I meant rem

Re: RFR: 8181313: SA: Remove libthread_db dependency on Linux

Looks good to me, Yasumasa. Thanks! Jini. On 1/11/2019 8:21 AM, Yasumasa Suenaga wrote: Hi Jini, I removed ps_get_thread_area() in new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8181313/webrev.02/ Diff from webrev.01 is here: http://hg.openjdk.java.net/jdk/submit/rev/691a931ae2b

Re: RFR: JDK-8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5

Thanks again, JC! :-) Folks, Could I please get one more review on this ? -Jini. On 1/11/2019 9:38 AM, JC Beyler wrote: Hi Jini, Looks good to me now :) Thanks for handling the comments :) Jc On Tue, Jan 8, 2019 at 8:11 PM Jini George > wrote: Thank you

Re: RFR (M) 8212959: Remove booleans from tests in vmTestbase

Hi David, Fair enough. I looked a bit to doing it anyway and it is self-contained in a lot of cases but a lot of times the work would be greatly simplified if we first factorized utility methods across test suites first and then (or at the same time) moved them to using bools and not doing the ex

Re: RFR (M) 8212959: Remove booleans from tests in vmTestbase

On 11/01/2019 3:20 pm, JC Beyler wrote: Hi David, Fair enough. I looked a bit to doing it anyway  and it is self-contained in a lot of cases but a lot of times the work would be greatly simplified if we first factorized utility methods across test suites first and then (or at the same time) m