Re: RFR (M) 8223040: Add a AGCT test

2019-05-04 Thread serguei.spit...@oracle.com
Hi Jc, Thank you for the update! It looks good to me. One question is why the .cpp name does not match the .java. (I expected it to be libASGCTBaseTest.cpp to match ASGCTBaseTest.java). Do you plan to keep one native agent library for all

Re: RFR (M) 8223040: Add a AGCT test

2019-05-04 Thread serguei.spit...@oracle.com
Hi Jc, Thank you for the update and answers! Thanks, Serguei On 5/4/19 14:01, Jean Christophe Beyler wrote: On Sat, May 4, 2019 at 2:53 AM serguei.spit...@oracle

Re: RFR (M) 8223044: Add back exception checking in tests

2019-05-04 Thread serguei.spit...@oracle.com
Hi Jc, On 5/4/19 14:12, Jean Christophe Beyler wrote: Hi Chris and Serguei, Then the new webrev is here: Webrev: http://cr.openjdk.java.net/~jcbeyler/8223044/webrev.01/ Bug: 

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-04 Thread 臧琳
Dear Serguei, Thanks a lot for your reviewing. System.err.println(" incremental dump support:"); +System.err.println("chunkcount=object number counted (in Kilo) to trigger incremental dump"); +System.err.println("maxfilesize= size limit of