RFR: 8235530: Removed duplicated threadByName methods in nsk/jdi tests

2019-12-07 Thread Leonid Mesnik
Hi Could you please review following fix which just remove duplicated threadByName methods and JDITestRuntimeException exceptions in nsk/jdi tests. I don't see any reason to have so many copies of them. The method threadByName is added nsk.share.jdi.Debugee class as 'threadByNameOrThrow' bec

Re: RFR: 8235530: Removed duplicated threadByName methods in nsk/jdi tests

2019-12-07 Thread serguei.spit...@oracle.com
Hi Leonid, The fix looks good. Thank you for taking care about it! I agree, it is an awful duplication. Thanks, Serguei On 12/7/19 18:17, Leonid Mesnik wrote: Hi Could you please review following fix which just remove duplicated threadByName methods and JDITestRuntimeException exceptions i

Re: RFR: 8235530: Removed duplicated threadByName methods in nsk/jdi tests

2019-12-07 Thread David Holmes
+1 on both counts Not sure JDITestRuntimeException is really necessary/useful versus just using RuntimeException, but that's a different issue. Thanks, David On 8/12/2019 2:30 pm, serguei.spit...@oracle.com wrote: Hi Leonid, The fix looks good. Thank you for taking care about it! I agree,