Please review a minor cleanup to remove code long since unnecessary.
The type of the BadAttributeValueExpException argument is String and
if it is not a string in the serialized stream, a suitable replacement
is created.
Issue: https://bugs.openjdk.java.net/browse/JDK-8232622
Patch:
diff --gi
Hi Roger,
I think you will need to preserve these cases:
On 13/02/2020 15:52, Roger Riggs wrote:
- || valObj instanceof Long
- || valObj instanceof Integer
- || valObj instanceof Float
- || valObj instanceof Double
- ||
Hi Richard,
I’m only commenting on the handshake changes.
I see that operation VM_EnterInterpOnlyMode can be called inside
operation VM_SetFramePop which also allows nested operations. Here is a
comment in VM_SetFramePop definition:
// Nested operation must be allowed for the VM_EnterInterpOn
Hi Daniel,
That's part of the technical debt that has to go.
The change to do the conversion in the constructor has been there since
JDK8.
And the value of the argument is informative.
There isn't too much overhead in keeping them but the are just noise at
this point.
Thanks, Roger
On 2/
Hi Roger,
OK - I can accept that then.
best regards,
-- daniel
On 13/02/2020 18:18, Roger Riggs wrote:
Hi Daniel,
That's part of the technical debt that has to go.
The change to do the conversion in the constructor has been there since
JDK8.
And the value of the argument is informative.
Hi,
Please review a tiny change to correct the VMState.hasListener implementation.
JBS: https://bugs.openjdk.java.net/browse/JDK-8239055
Webrev: http://cr.openjdk.java.net/~fmatte/8239055/webrev.00/
Thanks,
Fairoz
