Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-10 Thread serguei.spit...@oracle.com
Hi Chihiro, Yes, I'll sponsor it. Thank you for the update. Thanks, Serguei On 3/8/20 06:05, Chihiro Ito wrote: Hi, I'm sorry. I included "JDK-" in the changeset title. I removed it and updated it. Change set : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.06/changeset Regards, Chihi

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread Kevin Walls
Hi Yasumasa , The changes build OK for me in the latest jdk, and things still work. I have not yet seen the dwarf usage in action: I've tried a couple of different systems and so far have not reproduced the problem, i.e. jstack has not failed on native frames. I may need more recent basic lib

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread Yasumasa Suenaga
Hi Kevin, Thanks for your comment! On 2020/03/10 18:58, Kevin Walls wrote: Hi Yasumasa , The changes build OK for me in the latest jdk, and things still work. I have not yet seen the dwarf usage in action: I've tried a couple of different systems and so far have not reproduced the problem, i.

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

2020-03-10 Thread serguei.spit...@oracle.com
Hi Alex, The update looks good. Thanks, Serguei On 3/9/20 12:15, Alex Menkov wrote: Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev.02/ Changes are in LockFreeLogger comments only. --alex On 03/08/2020 21:19, David Holmes wrote: P.S. Forgot to

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread Kevin Walls
Hi - In testing I wasn't seeing any of the Dwarf code triggered. With LIBSAPROC_DEBUG set I'm getting the "Could not find executable section in" for lots of / maybe all the libraries... src/jdk.hotspot.agent/linux/native/libsaproc/libproc_impl.c    if (fill_instr_info(newlib)) { if (!re

Re: RFR(L) 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available

2020-03-10 Thread serguei.spit...@oracle.com
Hi Chris, Overall, this looks as a right direction to me while it is not easy to verify all the details. I'll make another pass tomorrow. A couple of quick nits so far: http://cr.openjdk.java.net/~cjplummer/8238268/webrev.00/test/hotspot/jtre

Re: RFR(L) 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available

2020-03-10 Thread Chris Plummer
On 3/10/20 6:07 PM, serguei.spit...@oracle.com wrote: Hi Chris, Overall, this looks as a right direction to me while it is not easy to verify all the details. Yes, there are a lot of tests with quite a few different ty

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread Yasumasa Suenaga
Hi Kevin, I guess first program header in the libraries which are on your machine has exec flag (you can check it with `readelf -l`). So I tweaked my patch (initial value of exec_start and exec_end set to -1) in new webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8234624/webrev.05/ This we

Re: RFR(L) 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available

2020-03-10 Thread serguei.spit...@oracle.com
On 3/10/20 18:57, Chris Plummer wrote: On 3/10/20 6:07 PM, serguei.spit...@oracle.com wrote: Hi Chris, Overall, this looks as a right direction to me while it is not easy to verify all the details.

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread Yasumasa Suenaga
Hi Kevin, I saw 2 errors on submit repo (mach5-one-ysuenaga-JDK-8234624-5-20200311-0209-9358475). So I tweaked my patch, but I saw the crash again (mach5-one-ysuenaga-JDK-8234624-5-20200311-0448-9361448). Last change on submit repo is here: http://cr.openjdk.java.net/~ysuenaga/JDK-823462

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread David Holmes
Hi Yasumasa, Partial hs_err info below. David - # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x7fdf2000e87c, pid=29798, tid=29800 # # JRE version: Java(TM) SE Runtime Environment (15.0) (fastdebug build 15-internal+0-2020-03-11-0447267.s

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread Yasumasa Suenaga
Thanks David! Can you share native backtrace? (Did /opt/core.sh collect it?) Yasumasa On 2020/03/11 14:59, David Holmes wrote: Hi Yasumasa, Partial hs_err info below. David - # # A fatal error has been detected by the Java Runtime Environment: # #  SIGSEGV (0xb) at pc=0x7fdf2000e8

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread David Holmes
On 11/03/2020 4:03 pm, Yasumasa Suenaga wrote: Thanks David! Can you share native backtrace? (Did /opt/core.sh collect it?) There is a core file but I can't process it, sorry. David - Yasumasa On 2020/03/11 14:59, David Holmes wrote: Hi Yasumasa, Partial hs_err info below. David -

Re: : PING: RFR: 8234624: jstack mixed mode should refer DWARF

2020-03-10 Thread Yasumasa Suenaga
On 2020/03/11 15:20, David Holmes wrote: On 11/03/2020 4:03 pm, Yasumasa Suenaga wrote: Thanks David! Can you share native backtrace? (Did /opt/core.sh collect it?) There is a core file but I can't process it, sorry. Can you share entire of hs_err log and libsaproc.so on this test? I cannot