Hi Yasumasa,
Oops, didn't catch this - I also had done some manual testing and in
mach5 but clearly not enough.
Generally I think this looks good.
"lastFrame" can mean last as in final, or last as in previous. "last" is
one of those annoying English words. Here it means final, if we get an
Hi Kevin,
Nice catch with the name "lastFrame".
I was also confused when reviewed this but did not come up with
something better.
Thanks,
Serguei
On 3/26/20 10:40, Kevin Walls wrote:
Hi Yasumasa,
Oops, didn't catch this - I also had done some manual testing and in
mach5 but clearly not
Hi Chris,
Looks good, thanks for fixing this.
Thanks,
Christian
> On Mar 26, 2020, at 1:27 PM, Chris Plummer wrote:
>
> Hello,
>
> Please review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8241696
>
> diff --git a/test/hotspot/jtreg/ProblemList.txt
>
Thanks!
On 3/26/20 1:55 PM, Daniel D. Daugherty wrote:
Thumbs up. This is a trivial review, but you didn't qualify it as such
so now you have a second review.
Dan
On 3/26/20 4:41 PM, Christian Tornqvist wrote:
Hi Chris,
Looks good, thanks for fixing this.
Thanks,
Christian
On Mar 26,
On 3/26/20 4:06 PM, David Holmes wrote:
Hi Leonid,
On 27/03/2020 7:39 am, Leonid Mesnik wrote:
Replying with correct summary.
Leonid
On 3/23/20 8:55 PM, Leonid Mesnik wrote:
Hi
Could you please review following fix which update ThreadsRunner to
use AtomicInteger/spinOnWait instead of
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8241696
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jtreg/ProblemList.txt
--- a/test/hotspot/jtreg/ProblemList.txt
+++ b/test/hotspot/jtreg/ProblemList.txt
@@ -85,7 +85,7 @@
Replying with correct summary.
Leonid
On 3/23/20 8:55 PM, Leonid Mesnik wrote:
Hi
Could you please review following fix which update ThreadsRunner to use
AtomicInteger/spinOnWait instead of Wicket to synchronize starting of stress
test threads.
Failing tests allocated all memory by earlier
Thumbs up. This is a trivial review, but you didn't qualify it as such
so now you have a second review.
Dan
On 3/26/20 4:41 PM, Christian Tornqvist wrote:
Hi Chris,
Looks good, thanks for fixing this.
Thanks,
Christian
On Mar 26, 2020, at 1:27 PM, Chris Plummer wrote:
Hello,
Please
Hi Claes,
Adding serviceability as they are the consumers of this IIUC.
On 27/03/2020 3:40 am, Claes Redestad wrote:
Hi,
PerfTraceTime::_recursion_counter is unused, and removing it
gets rid of some branchy (but well-predicted) code in paths that is
somewhat startup sensitive.
Okay.
On 3/26/20 4:29 PM, David Holmes wrote:
On 27/03/2020 9:16 am, Leonid Mesnik wrote:
On 3/26/20 4:06 PM, David Holmes wrote:
Hi Leonid,
On 27/03/2020 7:39 am, Leonid Mesnik wrote:
Replying with correct summary.
Leonid
On 3/23/20 8:55 PM, Leonid Mesnik wrote:
Hi
Could you please review
On 3/26/20 4:36 PM, David Holmes wrote:
Hi Claes,
Adding serviceability as they are the consumers of this IIUC.
On 27/03/2020 3:40 am, Claes Redestad wrote:
Hi,
PerfTraceTime::_recursion_counter is unused, and removing it
gets rid of some branchy (but well-predicted) code in paths that is
On 27/03/2020 9:16 am, Leonid Mesnik wrote:
On 3/26/20 4:06 PM, David Holmes wrote:
Hi Leonid,
On 27/03/2020 7:39 am, Leonid Mesnik wrote:
Replying with correct summary.
Leonid
On 3/23/20 8:55 PM, Leonid Mesnik wrote:
Hi
Could you please review following fix which update ThreadsRunner to
Please review the implementation of JEP 371: Hidden Classes. The main
changes are in core-libs and hotspot runtime area. Small changes are
made in javac, VM compiler (intrinsification of Class::isHiddenClass),
JFR, JDI, and jcmd. CSR [1]has been reviewed and is in the finalized
state (see
Hi Roman,
I'm okay with fix.
Thanks,
Serguei
On 3/26/20 17:15, serguei.spit...@oracle.com wrote:
Hi Roman,
Yes. Thank you for the explanation.
Thanks,
Serguei
On 3/26/20 01:44, Roman Kennke wrote:
That was in the previous implementation: I got a condition wrong in the
table lookup (as
Hi Roman,
Yes. Thank you for the explanation.
Thanks,
Serguei
On 3/26/20 01:44, Roman Kennke wrote:
That was in the previous implementation: I got a condition wrong in the
table lookup (as noted by Serguei), and this prevented any
class-unload-events from getting out. I have fixed this, but
Hi Claes,
On 27/03/2020 10:11 am, Claes Redestad wrote:
On 2020-03-27 00:36, David Holmes wrote:
Okay so can you change the bug synopsis and description to cover this
more general cleanup and tuneup please.
I filed an addendum RFE and will add this RFE bug id to the single
changeset
Thanks Kevin and Serguei! and sorry for my English...
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.05/
Diff from webrev.04 is here:
http://hg.openjdk.java.net/jdk/submit/rev/d5f400d70e94
Thanks,
Yasumasa
On 2020/03/27 2:53, serguei.spit...@oracle.com
On 2020-03-27 00:36, David Holmes wrote:
Okay so can you change the bug synopsis and description to cover this
more general cleanup and tuneup please.
I filed an addendum RFE and will add this RFE bug id to the single
changeset push:
https://bugs.openjdk.java.net/browse/JDK-8241705
All tests on submit repo has been passed.
(mach5-one-ysuenaga-JDK-8240956-3-20200327-0003-9753265)
Yasumasa
On 2020/03/27 9:07, Yasumasa Suenaga wrote:
Thanks Kevin and Serguei! and sorry for my English...
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.05/
On 27/03/2020 9:46 am, Chris Plummer wrote:
On 3/26/20 4:36 PM, David Holmes wrote:
Hi Claes,
Adding serviceability as they are the consumers of this IIUC.
On 27/03/2020 3:40 am, Claes Redestad wrote:
Hi,
PerfTraceTime::_recursion_counter is unused, and removing it
gets rid of some branchy
Hi Leonid,
On 27/03/2020 7:39 am, Leonid Mesnik wrote:
Replying with correct summary.
Leonid
On 3/23/20 8:55 PM, Leonid Mesnik wrote:
Hi
Could you please review following fix which update ThreadsRunner to
use AtomicInteger/spinOnWait instead of Wicket to synchronize starting
of stress
That was in the previous implementation: I got a condition wrong in the
table lookup (as noted by Serguei), and this prevented any
class-unload-events from getting out. I have fixed this, but found other
problems in that implementation (deadlocks and a crash).
The current implementation has none
Hi Yasumasa and Serguei,
Thank you for reviewing this change.
Best regards,
--Daniil
On 3/25/20, 1:01 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
On 3/24/20 10:00, Daniil Titov wrote:
> Hi Serguei,
>
>> It looks like you removed the last call site of
Hi Roman,
Yes. Thank you.
Chris
On 3/26/20 1:44 AM, Roman Kennke wrote:
That was in the previous implementation: I got a condition wrong in the
table lookup (as noted by Serguei), and this prevented any
class-unload-events from getting out. I have fixed this, but found other
problems in that
24 matches
Mail list logo
