Hi Yasumasa,
On 4/5/20 11:56 PM, Yasumasa Suenaga wrote:
Hi Chris,
On 2020/04/06 15:46, Chris Plummer wrote:
Hi Yasumasa,
I'm not sure what you mean by "conflict some keys". Can you explain?
System properties stores in ConcurrentHashMap. `next` field would be
used when hashcode of key stri
Hi Chris,
Thank you for explanation.
I think it is difficult to store the property in same hashcode.
So your change looks good.
Yasumasa
On 2020/04/06 16:18, Chris Plummer wrote:
Hi Yasumasa,
On 4/5/20 11:56 PM, Yasumasa Suenaga wrote:
Hi Chris,
On 2020/04/06 15:46, Chris Plummer wrote:
Hi Mandy,
Two JDI tests started failing with the update of
src/jdk.jdi/share/classes/com/sun/tools/jdi/EventSetImpl.java:
vmTestbase/nsk/jdi/ClassUnloadRequest/addClassFilter/filter001/TestDescription.java
vmTestbase/nsk/jdi/ClassUnloadEvent/
Sorry for sending mach5 links to the
open mailing lists, I've removed them below.
Thanks,
serguei
On 4/6/20 09:56, serguei.spit...@oracle.com wrote:
Hi Mandy,
Two JDI tests started failing with the update of
Hi Serguei,
This fix looks good.
thanks,
Chris
On 4/6/20 10:05 AM, serguei.spit...@oracle.com wrote:
Sorry for sending mach5 links to the
open mailing lists, I've removed them below.
Thank
Thanks, Chris!
What do you think about this suggestion from Mandy:
Is ClassUnloadEvent only sent for non-array reference type?
If so, is it worth adding an assert
like
assert classSignature.startsWith('L') &&
classSignature.en
Hi Serguei,
I think that's fine but I don't think it should be done in the
context of this Vahalla webrev since it has nothing to do with
Vahalla. I'd suggest filing an RFE and pushing it to jdk/jdk.
Easier to track that way if there are issues down the roa
Hi Chris,
Okay, I'll file an RFE.
Thanks,
Serguei
On 4/6/20 11:00, Chris Plummer wrote:
Hi Serguei,
I think that's fine but I don't think it should be done in the
context of this Vahalla webrev s
On 4/6/20 9:56 AM, serguei.spit...@oracle.com wrote:
The suggested fix is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-regression-8242166.1/
This patch looks okay. I'll include in my local patch.
On 4/6/20 11:00 AM, Chris Plummer wrote:
I think that's fine but I don't th
On 4/6/20 11:54, Mandy Chung wrote:
On 4/6/20 9:56 AM, serguei.spit...@oracle.com wrote:
The suggested fix is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-regression-8242166.1/
This patch looks okay. I'll include in my local patch.
On 4/6/20 11:00 AM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242235
http://cr.openjdk.java.net/~cjplummer/8242235/webrev.00
The SA problem list entries due to JDK-8193639 [1] have been a burden to
maintain, and are badly out of date. Easiest solution is to remove them
and dis
On 4/6/20 4:10 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242235
http://cr.openjdk.java.net/~cjplummer/8242235/webrev.00
test/hotspot/jtreg/ProblemList.txt
No comments.
test/jdk/ProblemList.txt
No comments.
test/lib/jdk/tes
Looks good (not a Reviewer).
Leonid
On 4/5/20 11:49 PM, Chris Plummer wrote:
[Sorry about the resend. Subject wasn't quite right the first time.]
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8242168
http://cr.openjdk.java.net/~cjplummer/8242168/webrev.00/
LGTM
--alex
On 04/06/2020 13:10, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242235
http://cr.openjdk.java.net/~cjplummer/8242235/webrev.00
The SA problem list entries due to JDK-8193639 [1] have been a burden to
maintain, and are badly
LGTM
— Igor
> On Apr 5, 2020, at 11:49 PM, Chris Plummer wrote:
>
> [Sorry about the resend. Subject wasn't quite right the first time.]
>
> Hello,
>
> Please help review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8242168
> http://cr.openjdk.java.net/~cjplummer/8242168/webr
On 4/6/20 1:21 PM, Daniel D. Daugherty wrote:
On 4/6/20 4:10 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242235
http://cr.openjdk.java.net/~cjplummer/8242235/webrev.00
test/hotspot/jtreg/ProblemList.txt
No comments.
test/jdk/Pro
On 4/6/20 5:08 PM, Chris Plummer wrote:
On 4/6/20 1:21 PM, Daniel D. Daugherty wrote:
On 4/6/20 4:10 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242235
http://cr.openjdk.java.net/~cjplummer/8242235/webrev.00
test/hotspot/jtreg/Probl
Thanks Igor and Leonid!
Chris
On 4/6/20 1:38 PM, Igor Ignatev wrote:
LGTM
— Igor
On Apr 5, 2020, at 11:49 PM, Chris Plummer wrote:
[Sorry about the resend. Subject wasn't quite right the first time.]
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8242
Can I get one more review please?
thanks,
Chris
On 4/3/20 6:56 PM, Chris Plummer wrote:
Here's an updated webrev. I also renamed APP_CLASSNAME to
APP_SLASH_CLASSNAME just to make it a bit more clear which format is
being used.
http://cr.openjdk.java.net/~cjplummer/8242142/webrev.01
thanks,
Hi Chris,
This looks good.
Thanks,
Serguei
On 4/6/20 17:07, Chris Plummer wrote:
Can I get one more review please?
thanks,
Chris
On 4/3/20 6:56 PM, Chris Plummer wrote:
Here's an updated webrev. I also renamed APP_CLASSNAME to
APP_SLASH_CLASSNAME just to make it a bit more clear which fo
Hi Chris,
Quick question:
Should the
serviceability/sa/LingeredAppSysProps.java be also problem
listed?
Thanks,
Serguei
On 4/5/20 22:49, Chris Plummer wrote:
Hello,
Please help review t
Thank you Serguei!
Chris
On 4/6/20 6:02 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
This looks good.
Thanks,
Serguei
On 4/6/20 17:07, Chris Plummer wrote:
Can I get one more review please?
thanks,
Chris
On 4/3/20 6:56 PM, Chris Plummer wrote:
Here's an updated webrev. I also rename
It's not a test. It a subclassed LingeredApp with code added to print
all the system properties. But in any case I'm going to remove the
problem listing in this webrev since I will push
https://bugs.openjdk.java.net/browse/JDK-8242235 first, which gets rid
of the need to problem list on solaris
Okay, thanks!
Serguei
On 4/6/20 18:54, Chris Plummer wrote:
It's not a test. It a subclassed LingeredApp with code added to print
all the system properties. But in any case I'm going to remove the
problem listing in this webrev since I will push
https://bugs.openjdk.java.net/browse/JDK-824223
24 matches
Mail list logo
