Hi Magnus,
It looks good to me.
Thanks,
Serguei
On 4/15/20 06:00, Magnus Ihse Bursie wrote:
Here is an updated version, that avoids the SuppressWarnings for
modelToView:
http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02
(Only change is in
On 4/16/20 11:42 AM, serguei.spit...@oracle.com wrote:
Hi Mandy,
I have a couple of minor comments on the Serviceability spec update.
Hi Mandy,
I have a couple of minor comments on the Serviceability spec
update.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.06-svc-spec-changes/src/jdk.jdi/share/classes/com/sun/jdi/ReferenceType.java.udiff.html
Hi Ioi,
Regarding the changes in javaClasses.cpp, I saw that in your new code in
systemDictionaryShared.cpp, the
java_lang_Class::update_archived_mirror_native_pointers(m) won't be
called if MetaspaceShared::relocation_delta() is 0. But I noticed
there's another code path to
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242787
http://cr.openjdk.java.net/~cjplummer/8242787/webrev.00/index.html
After fixing JDK-8230731 [1], this test still failed, this time with a
WrongTypeException. The issue is basically the same one as was just
On 4/16/20 10:08 AM, Calvin Cheung wrote:
Hi Ioi,
Regarding the changes in javaClasses.cpp, I saw that in your new code
in systemDictionaryShared.cpp, the
java_lang_Class::update_archived_mirror_native_pointers(m) won't be
called if MetaspaceShared::relocation_delta() is 0. But I noticed
On 4/14/20 11:51 AM, Paul Sandoz wrote:
Looks good to me (not familiar with all the code areas.
Minor suggestion:
MethodHandles.java
1811 * ASCII periods. For the instance of {@link java.lang.Class}
representing {@code C}:
1812 *
1813 * {@link Class#getName()}
On 4/16/20 11:12 AM, Ioi Lam wrote:
On 4/16/20 10:08 AM, Calvin Cheung wrote:
Hi Ioi,
Regarding the changes in javaClasses.cpp, I saw that in your new code
in systemDictionaryShared.cpp, the
java_lang_Class::update_archived_mirror_native_pointers(m) won't be
called if
Hi Severin,
Thanks for your review and very nice suggestions.
Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.01/
test/hotspot/jtreg/containers/docker/TestGetFreeSwapSpaceSize.java is added to
reproduce the bug.
Thanks a lot.
Best regards,
Jie
On 2020/4/16, 4:40 PM, "Severin
This is the final part of removing all warnings from the build of
jdk.hotspot.agent. This patch includes a number of non-trivial fixes for
the few remaining unchecked warnings.
The good news is that with this fix (and after the recent removal of
Nashorn and rmic), the JDK build is finally
On 2020-04-16 04:37, coleen.phillim...@oracle.com wrote:
On 4/15/20 9:37 PM, David Holmes wrote:
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at
http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
bug link
On 4/16/20 10:24 AM, Magnus Ihse Bursie wrote:
On 2020-04-16 04:37, coleen.phillim...@oracle.com wrote:
On 4/15/20 9:37 PM, David Holmes wrote:
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at
Hi Jie,
On Thu, 2020-04-16 at 13:23 +, jiefu(傅杰) wrote:
> Hi Severin,
>
> Thanks for your review and very nice suggestions.
Thanks for adding a test!
> Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.01/
>
> test/hotspot/jtreg/containers/docker/TestGetFreeSwapSpaceSize.java is
>
Okay, thanks.
Non-serviceability changes look good too.
Thanks,
Serguei
On 4/16/20 11:48, Mandy Chung wrote:
On 4/16/20 11:42 AM, serguei.spit...@oracle.com wrote:
Hi Mandy,
I have a
Hi Jie,
On 16/04/2020 11:23 pm, jiefu(傅杰) wrote:
Hi Severin,
Thanks for your review and very nice suggestions.
Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.01/
test/hotspot/jtreg/containers/docker/TestGetFreeSwapSpaceSize.java is added to
reproduce the bug.
Can you please
On 4/16/20 9:17 PM, David Holmes wrote:
Hi Chris,
On 17/04/2020 3:18 am, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242787
http://cr.openjdk.java.net/~cjplummer/8242787/webrev.00/index.html
After fixing JDK-8230731 [1], this test still
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI code.
The two that are now stubbed out would have been no-ops without JVMTI as
old_compiled_method_table would have been NULL.
Still seems trivial to me.
Thanks,
David
On 17/04/2020 1:14 am,
Hi Chris,
On 17/04/2020 3:18 am, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242787
http://cr.openjdk.java.net/~cjplummer/8242787/webrev.00/index.html
After fixing JDK-8230731 [1], this test still failed, this time with a
Hi Chris,
This change looks good to me.
Thanks
- Ioi
On 4/16/20 10:18 AM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242787
http://cr.openjdk.java.net/~cjplummer/8242787/webrev.00/index.html
After fixing JDK-8230731 [1], this test
Hi Yasumasa,
Thank you for the update.
It looks good.
Thanks,
Serguei
On 4/10/20 04:30, Yasumasa Suenaga wrote:
Hi Serguei,
I use current_jt in this webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242425/webrev.02/
I tested this change with
On 4/16/20 11:55 AM, Calvin Cheung wrote:
On 4/16/20 11:12 AM, Ioi Lam wrote:
On 4/16/20 10:08 AM, Calvin Cheung wrote:
Hi Ioi,
Regarding the changes in javaClasses.cpp, I saw that in your new
code in systemDictionaryShared.cpp, the
Hi Chris,
This looks good.
Thanks,
Serguei
On 4/16/20 10:18, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242787
http://cr.openjdk.java.net/~cjplummer/8242787/webrev.00/index.html
After fixing JDK-8230731 [1], this test still failed,
Hi Chris,
The fix looks good to me.
--alex
On 04/16/2020 10:18, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242787
http://cr.openjdk.java.net/~cjplummer/8242787/webrev.00/index.html
After fixing JDK-8230731 [1], this test still failed,
Thanks Serguei!
Yasumasa
On 2020/04/17 5:13, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Thank you for the update.
It looks good.
Thanks,
Serguei
On 4/10/20 04:30, Yasumasa Suenaga wrote:
Hi Serguei,
I use current_jt in this webrev. Could you review again?
Hi Jie,
On Fri, 2020-04-10 at 01:49 +, jiefu(傅杰) wrote:
> Hi all,
>
> JBS:https://bugs.openjdk.java.net/browse/JDK-8242480
> Webrev: http://cr.openjdk.java.net/~jiefu/8242480/webrev.00/
>
> Negative values were returned by getFreeSwapSpaceSize() in our docker testing.
> The reason is
25 matches
Mail list logo
