Hi Chris,
I will revoke this RFR and resubmit it under JDK-8242009
with the changes you suggested to use Utils.getTestJavaOpts()
and make JDKToolLauncher to have an option to forward VM options.
> Is your change causing -Xshowversion to be passed?
Yes, the changes makes tests run with -Xshowv
Correction...
The option name is -showversion, not "-Xshowversion"
Best regards,
Daniil
On 4/23/20, 10:18 AM, "Daniil Titov" wrote:
Hi Chris,
I will revoke this RFR and resubmit it under JDK-8242009
with the changes you suggested to use Utils.getTestJavaOpts()
and make JDKToo
Thanks, Ioi!
Coleen
On 4/23/20 12:43 PM, Ioi Lam wrote:
Hi Coleen,
The changes look good to me.
Thanks
- Ioi
On 4/21/20 1:12 PM, coleen.phillim...@oracle.com wrote:
Summary: moved fields around and some constant fields into ConstantPool
This is a simple change except that I moved some const
On 4/23/20 10:18 AM, Daniil Titov wrote:
Hi Chris,
I will revoke this RFR and resubmit it under JDK-8242009
with the changes you suggested to use Utils.getTestJavaOpts()
and make JDKToolLauncher to have an option to forward VM options.
It could also be done with a new API such as
JDKToolLaunch
Hi Daniil
Have you checked how longer tests are executed with adding java options
to launchers (with Xcomp/Graal/ZGC)?
If the overhead is not significant might be it make worth to add options
by default? The idea is to add vm.opts to all processes and java.opts to
tested only. But if you bel
OK, thanks, looks good!
dl
On 4/22/20 7:32 PM, coleen.phillim...@oracle.com wrote:
On 4/22/20 9:00 PM, Dean Long wrote:
It looks like calling the JVMCI getSourceFileName() on an array would
have accessed random memory because it was expecting an
InstanceKlass. Instead of returning null we
Thanks, Dean!
Coleen
On 4/23/20 4:16 PM, Dean Long wrote:
OK, thanks, looks good!
dl
On 4/22/20 7:32 PM, coleen.phillim...@oracle.com wrote:
On 4/22/20 9:00 PM, Dean Long wrote:
It looks like calling the JVMCI getSourceFileName() on an array
would have accessed random memory because it was
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8231634
http://cr.openjdk.java.net/~cjplummer/8231634/webrev.00/index.html
The fix is fairly simple: Don't use R13 as the BCP if it does not point
into the methods actual bytecodes. Instead rely on the BCP value
Please, review a fix for the sub-task:
https://bugs.openjdk.java.net/browse/JDK-8241807
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-events.4/
Summary;
This sub-task is to cover any hidden class related remaining
