Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (hotspot)

2020-05-07 Thread Igor Ignatyev
Hi Mikael, yes, Vladimir's reply made it clear, let's hope all the needed changes got upstream before the next graal update so it goes smoothly. Cheers, -- Igor > On May 6, 2020, at 10:27 PM, Mikael Vidstedt > wrote: > > > Igor, thank you for the review, and again for helping make the test

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

2020-05-07 Thread serguei.spit...@oracle.com
Hi Mikael, The summary looks correct. The fix looks good to me. Thanks, Serguei On 5/6/20 22:44, Mikael Vidstedt wrote: To summarize the status: I have not made any changes to the serviceability patch itself, but I did remove generateJvmOffsets.cpp as part of the build system patch. I belie

Ping: RFR: JDK-8243012: Fix issues in j.l.i package info

2020-05-07 Thread Alex Menkov
On 05/01/2020 15:22, Alex Menkov wrote: Hi all, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8243012 The change fixes security note in the java.lang.instrument javadoc. webrev: http://cr.openjdk.java.net/~amenkov/jdk15/java_instrument_spec/webrev.1/ --alex

Re: RFR: 8242009: Review setting test.java/vm.opts in jcmd/jhsdb and debugger in serviceability tests

2020-05-07 Thread Chris Plummer
Hi Daniil, The changes look good. thanks, Chris On 5/4/20 1:05 PM, Daniil Titov wrote: Hi Chris, Please review a new version of webrev [1] that addresses your comments. For the following 3 tests that showed the increase of the execution time with -Xcomp more than 5 minutes this version of