Re: RFR 8244105: JDK 11.0.7 -Xlog gc issue with file path if not exist

Hi Harold, On 9/05/2020 3:22 am, Harold Seigel wrote: Hi, Please review this fix for JDK-8244105.  The fix continues program execution even when specified logging options are invalid.  Previously, invalid logging options terminated the program.  Now, a warning is issued.  For example:

Re: RFR 8244105: JDK 11.0.7 -Xlog gc issue with file path if not exist

On 12/05/2020 1:06 am, dmytro sheyko wrote: Hi, I think it would be very convenient for app developers if JVM were able to create intermediate directories to gc.log file if they do not exist. You can file a RFE for that, but personally I don't think it is something the VM should do. Cheers

Re: Ping: RFR: JDK-8243012: Fix issues in j.l.i package info

On 11/05/2020 22:14, Alex Menkov wrote: Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/java_instrument_spec/webrev.2/ --alex This doesn't work for me because it drops the important point that the developer/admin is also responsible when deploying an agent that packages an agent wi

RE: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

Hi Richard, I had already reviewed webrev.1. Looks good to me. Thanks for contributing it. Best regards, Martin > -Original Message- > From: hotspot-runtime-dev boun...@openjdk.java.net> On Behalf Of Reingruber, Richard > Sent: Montag, 4. Mai 2020 12:33 > To: David Holmes ; serviceabil

RE: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

Thanks Martin. Cheers, Richard. -Original Message- From: Doerr, Martin Sent: Dienstag, 12. Mai 2020 10:43 To: Reingruber, Richard ; David Holmes ; serviceability-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; hotspot-...@openjdk.java.net; hotspot-runtime-...@openjdk.jav

Re: RFR 8244105: JDK 11.0.7 -Xlog gc issue with file path if not exist

Hi David, Thanks for looking at this. This change disables logging and issuing a warning for any errors in the -Xlog arguments that currently cause the JVM to terminate. For which particular bad -Xlog arguments do you think this is a bad idea? Are there some bad -Xlog arguments where you thi

Re: RFR: 8242009: Review setting test.java/vm.opts in jcmd/jhsdb and debugger in serviceability tests

Hi Chris, Thank you for reviewing this change. Best regards, Daniil On 5/11/20, 10:55 AM, "Chris Plummer" wrote: Hi Daniil, Looks good. thanks, Chris On 5/11/20 9:43 AM, Daniil Titov wrote: > Hi Chris, > > Please review a new version of the fix[1] that also

Re: Ping: RFR: JDK-8243012: Fix issues in j.l.i package info

Hi Alan, Serguei, lets try one more time :) What about: Agents can transform classes in arbitrary ways at load time, transform modules, or transform the bytecode of methods of already loaded classes. Developers or administrators that deploy agents, deploy applications that package an agent with

Re: Ping: RFR: JDK-8243012: Fix issues in j.l.i package info

Hi Alex, This seems to resolve most of the Alan's concerns. Though, I'm not sure if we can treat users that deploy and use agents as developers. Otherwise, we may want to tweak the last sentence a little bit:  "Developers or administrators that deploy agents, deploy applications that package

Re: RFR 8244105: JDK 11.0.7 -Xlog gc issue with file path if not exist

Hi Harold, On 12/05/2020 10:49 pm, Harold Seigel wrote: Hi David, Thanks for looking at this. This change disables logging and issuing a warning for any errors in the -Xlog arguments that currently cause the JVM to terminate. For which particular bad -Xlog arguments do you think this is a ba

Re: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

On 4/05/2020 8:33 pm, Reingruber, Richard wrote: // Trimmed the list of recipients. If the list gets too long then the message needs to be approved // by a moderator. Yes I noticed that too :) In general if you send to hotspot-dev you shouldn't need to also send to hotspot-X-dev. Hi David,