Re: RFR (M) 8249768: Move static oops and NullPointerException oops from Universe into OopStorage

On 7/20/20 10:47 PM, David Holmes wrote: Hi Coleen, cc'ing serviceability due to SA changes. On 21/07/2020 6:53 am, coleen.phillim...@oracle.com wrote: Summary: Move static oops into OopStorage and make NPE oops an objArrayOop. I've broken up moving oops in Universe to OopStorage into sev

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

This looks like a nice cleanup. http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/src/hotspot/share/runtime/jniHandles.cpp.udiff.html I'm wondering why you took out the NULL return for make_local() without a thread argument?  Here you may call Thread::current() unnecessarily. jobject JN

Re: [15?] RFR (S): 8249192: MonitorInfo stores raw oops across safepoints

Hi Coleen and David, thanks for your reviews. On 21.07.20 03:29, David Holmes wrote: Hi Thomas, On 21/07/2020 12:49 am, Thomas Schatzl wrote: Forwarding to hotspot-dev where it belongs after wrongly sending to hotspot-gc-dev. This touches serviceability code as well so cc'ing for good mea

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

One note below: On 7/20/20 1:53 AM, David Holmes wrote: Hi Kim, Thanks for looking at this. Updated webrev at: http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/ On 20/07/2020 3:22 pm, Kim Barrett wrote: On Jul 20, 2020, at 12:16 AM, David Holmes wrote: Subject line got truncated b

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

Hi David, The fix looks good to me. Thanks, Serguei On 7/19/20 22:53, David Holmes wrote: Hi Kim, Thanks for looking at this. Updated webrev at: http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/ On 20/07/2020 3:22 pm, Kim Barrett wrote: On Jul 20, 2020, at 12:16 AM, David Holmes w

Re: RFR(M): 8247515: OSX pc_to_symbol() lookup does not work with core files

Hi Serguei and Kevin, The webrev has been updated: http://cr.openjdk.java.net/~cjplummer/8247515/webrev.02/index.html https://bugs.openjdk.java.net/browse/JDK-8247515 Two issues were addressed: (1) Code in symbol_for_pc() assumed

RFR(S): 8248882: SA PMap and PStack support on OSX works with core files. Enable them.

Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8248882 http://cr.openjdk.java.net/~cjplummer/8248882/webrev.00/index.html The changes enable PMap and PStack on OSX when debugging a core file. Unfortunately there appears to be no exposed way to determine if yo

RFR: JDK-8249550: jdb should use loopback address when not using remote agent

Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8249550 webrev: http://cr.openjdk.java.net/~amenkov/jdk16/jdb_loopback/webrev/ some background: https://bugs.openjdk.java.net/browse/JDK-8041435 made default listening on loopback address. Later https://bugs.openjdk.jav

Re: [15?] RFR (S): 8249192: MonitorInfo stores raw oops across safepoints

Hi Thomas, I've looked at the incremental update and I am happy with that. I also, prompted by you mentioning it, took a deeper look at the biased-locking code to ensure it also keeps the MonitorInfo's thread-confined, and to see whether the handshake versions could themselves be susceptible

Re: [15?] RFR (S): 8249192: MonitorInfo stores raw oops across safepoints

Hi Thomas, The fix looks okay to me. The 15 fix is identical to 16. This file finally was not changed: src/hotspot/share/runtime/vframe_hp.cpp . Several files need a copyright comment update. What tests do you run? We need at least tier3 to make sure there are no regressions in the JVMTI and J

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

Thanks Serguei! David On 22/07/2020 5:25 am, serguei.spit...@oracle.com wrote: Hi David, The fix looks good to me. Thanks, Serguei On 7/19/20 22:53, David Holmes wrote: Hi Kim, Thanks for looking at this. Updated webrev at: http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/ On 20/

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

Hi Dan, On 21/07/2020 3:07 am, Daniel D. Daugherty wrote: On 7/20/20 1:53 AM, David Holmes wrote: Hi Kim, Thanks for looking at this. Updated webrev at: http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/ I like this cleanup very much! Thanks for looking at it. src/hotspot/share/cl

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

Hi Coleen, On 22/07/2020 4:01 am, coleen.phillim...@oracle.com wrote: This looks like a nice cleanup. Thanks for looking at this. http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/src/hotspot/share/runtime/jniHandles.cpp.udiff.html I'm wondering why you took out the NULL return for mak

Re: RFR: 8216324: GetClassMethods is confused by the presence of default methods in super interfaces

Hi Serguei and Alex, Please, review new version of the change [1] that includes changes as Serguei suggested. > 114 default void default_method() { } // should never be seen > The comment above is not clear. Should never be seen in what context? This method should not be included in the lis

Re: RFR: 8216324: GetClassMethods is confused by the presence of default methods in super interfaces

Hi Daniil, Thank you for the update! It looks good to me. Just two more minor comments and no need for another webrev you address them. 2519 int skipped = 0; // skip default methods Saying "overpass methods" would be more precise.

Re: RFR (M) 8249768: Move static oops and NullPointerException oops from Universe into OopStorage

Hi Coleen, On 22/07/2020 12:19 am, coleen.phillim...@oracle.com wrote: On 7/20/20 10:47 PM, David Holmes wrote: Hi Coleen, cc'ing serviceability due to SA changes. On 21/07/2020 6:53 am, coleen.phillim...@oracle.com wrote: Summary: Move static oops into OopStorage and make NPE oops an objA