Hi Serguei,
On 2020/09/02 15:29, David Holmes wrote:
Hi Serguei,
On 2/09/2020 4:11 pm, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It seems to me your update for sync with the JvmtiThreadState_lock is incorrect.
Let me explain it.
The original design was that the functions is_frame_pop, se
Hi David,
On 9/1/20 23:29, David Holmes wrote:
Hi Serguei,
On 2/09/2020 4:11 pm, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It seems to me your update for sync with the JvmtiThreadState_lock is
incorrect.
Let me explain it.
The original design was that the functions is_frame_pop,
set_
Hi Serguei,
On 2/09/2020 5:10 pm, serguei.spit...@oracle.com wrote:
Hi David,
On 9/1/20 23:29, David Holmes wrote:
Hi Serguei,
On 2/09/2020 4:11 pm, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It seems to me your update for sync with the JvmtiThreadState_lock is
incorrect.
Let me expl
Hi David,
On 9/2/20 00:32, David Holmes wrote:
Hi Serguei,
On 2/09/2020 5:10 pm, serguei.spit...@oracle.com wrote:
Hi David,
On 9/1/20 23:29, David Holmes wrote:
Hi Serguei,
On 2/09/2020 4:11 pm, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It seems to me your update for sync with the
Hi Yasumasa,
Thank you for the explanation. At least, I see the real motivation.
I've overlooked this in the email thread.
Thanks,
Serguei
On 9/2/20 00:00, Yasumasa Suenaga wrote:
Hi Serguei,
On 2020/09/02 15:29, David Holmes wrote:
Hi Serguei,
On 2/09/2020 4:11 pm, serguei.spit...@oracle.
Hi Serguei,
I have to confess I am not at all clear eactly what interactions the
JvmtiThreadState_lock is supposed to serializing. :(
I'm no longer convinced that holding that lock in place of executing at
a safepoint is either necessary nor sufficient.
David
On 2/09/2020 6:38 pm, serguei.
On 01/09/2020 09:57, David Holmes wrote:
> We already build with gcc 9.2 and don't see any issues with shared code
> compiling for hotspot - which of these require --enable-asan? It
> certainly looks like an unnecessary warning - the whole point of strncpy
> is to truncate at a safe length. :(
Yes
Hi David,
I do not see any obvious problems yet.
But let me double-check everything tomorrow.
Thanks,
Serguei
On 9/2/20 02:14, David Holmes wrote:
Hi Serguei,
I have to confess I am not at all clear eactly what interactions the
JvmtiThreadState_lock is supposed to serializing. :(
I'm no l
Hi Robbin,
// taking the discussion back to the mailing lists
> I still don't understand why you don't deoptimize the objects inside the
> handshake/safepoint instead?
This is unfortunately not possible. Deoptimizing objects includes reallocating
scalar replaced objects, i.e. calling Deopti
Hi David,
Thanks for your review and sorry for the delay.
David Holmes on Tue Sep 1 08:57:01 UTC 2020
> We already build with gcc 9.2 and don't see any issues with shared code
> compiling for hotspot - which of these require --enable-asan? It
> certainly looks like an unnecessary warning - th
Hi,
please help review this fix for a TESTBUG in
serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java
Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8252593/webrev.0/
Bug:https://bugs.openjdk.java.net/browse/JDK-8252593
With this change the JVMTI test agent silently acce
Hi Richard,
On 2020-09-02 15:48, Reingruber, Richard wrote:
Hi Robbin,
// taking the discussion back to the mailing lists
> I still don't understand why you don't deoptimize the objects inside the
> handshake/safepoint instead?
So for handshakes using asynch handshake and allowing bloc
Hi Richard,
This looks reasonable to me.
The only question is about the quality of this testing.
How are we sure these errors are caused by races but not bugs in
the GetLocalObject implementation?
Thanks,
Serguei
On 9/
Hi Robin,
> On 2020-09-02 15:48, Reingruber, Richard wrote:
> > Hi Robbin,
> >
> > // taking the discussion back to the mailing lists
> >
> >> I still don't understand why you don't deoptimize the objects inside
> > the
> >> handshake/safepoint instead?
> So for handshakes using asynch
Hi Richard,
On 3/09/2020 12:37 am, Reingruber, Richard wrote:
Hi,
please help review this fix for a TESTBUG in
serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java
Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8252593/webrev.0/
Bug: https://bugs.openjdk.java.net/browse
15 matches
Mail list logo
